Skip to content

Commit f236916

Browse files
authored
more proper version comparision
1 parent eb871a4 commit f236916

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

scripts/version.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,13 @@ const resolve = (...args) => path.resolve(__dirname, ...args);
99

1010
const MAX_TAGS_LIMIT = 64;
1111

12+
function isGreater(a, b) {
13+
const cmp = semver.compare(semver.coerce(a), semver.coerce(b));
14+
return cmp === 0
15+
? a.includes("nightly") && !b.includes("nightly")
16+
: cmp > 0;
17+
}
18+
1219
const createRepo = (path, regex, mapVersion) => ({
1320
git: simpleGit(path),
1421
filter: tag => {
@@ -52,7 +59,7 @@ async function main() {
5259
let { version: srcVer } = await latest(src);
5360
let { version: dstVer } = await latest(dst);
5461

55-
if (!dstVer || semver.gt(srcVer, dstVer)) {
62+
if (!dstVer || isGreater(srcVer, dstVer)) {
5663
console.log(srcVer);
5764
} else {
5865
console.log(`${srcVer}-nightly.${dateFormat(Date.UTC(), "yyyymmdd")}`);

0 commit comments

Comments
 (0)