-
Notifications
You must be signed in to change notification settings - Fork 1
Add Kipp zonen shadow ring correction function #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AdamRJensen
wants to merge
5
commits into
main
Choose a base branch
from
kipp_zonen_shadow_ring_correction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cdb6252
Add K&Z shadow ring adjustment function
AdamRJensen 7f80b91
Update kipp_zonen_shadow_ring_sliding_bar_setting.py
AdamRJensen 4cf5ed9
Apply suggestions from code review
AdamRJensen 181163c
Use function instead of interpolation
AdamRJensen 1cf88be
Corrections from review
AdamRJensen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| """Script for generating slide bar settings for Kipp & Zonen shadow ring.""" | ||
|
|
||
| import numpy as np | ||
| import pandas as pd | ||
| import pvlib | ||
|
|
||
| # Information has been taken from the Kipp & Zonen CM 121 shadow ring | ||
| # instruction manual. | ||
|
|
||
| # Note that the correction factors are based on the assumption of a horizontal | ||
| # pyranometer installation and uniform diffuse sky irradiance. | ||
|
|
||
| # The sliding bar has two scales; a higher and a lower one. At | ||
| # positive solar declinations (between 21 Mar. and 23 Sep.) the part of the | ||
| # scale that is oriented south must be read. In the northern hemisphere this is | ||
| # the lower part. | ||
|
|
||
| # The sliding bar adjustment can be derived with the formula | ||
| # L = abs(297 tan (D)), in which D is the declination of the sun. | ||
|
|
||
|
|
||
| def calculate_sliding_bar_setting(declination): | ||
| """ | ||
| Determine Kipp & Zonen shadow ring sliding bar setting. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| declination : numeric | ||
| Declination angle [degrees]. | ||
|
|
||
| Returns | ||
| ------- | ||
| numeric | ||
| Sliding bar setting [cm]. | ||
|
|
||
| """ | ||
| sliding_bar_mm = 297 * np.tan(np.deg2rad(np.abs(declination))) | ||
| sliding_bar_cm = np.round(sliding_bar_mm / 10, 1) | ||
| return sliding_bar_cm | ||
|
|
||
|
|
||
| times = pd.date_range(start='2025-01-01', end='2025-12-31', freq='1d') | ||
|
|
||
| declination = \ | ||
| np.rad2deg(pvlib.solarposition.declination_spencer71(times.dayofyear)) | ||
|
|
||
| slide_bar = calculate_sliding_bar_setting(declination) | ||
|
|
||
| df = pd.DataFrame( | ||
| data={ | ||
| 'Slide bar setting': slide_bar, | ||
| }, | ||
| index=[times.strftime('%m %b'), times.day] | ||
| ) | ||
|
|
||
| df = df.unstack(0)['Slide bar setting'] | ||
|
|
||
| df = df.fillna('') | ||
|
|
||
| df.columns = [c.split(' ')[-1] for c in df.columns] | ||
|
|
||
| df.to_excel('../metadata/kipp_zonen_shadow_ring_slide_bar_setting.xlsx') | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't really see the lower part of the scale, given where the shadow ring is installed... maybe the "smart" thing to do would be to convert the values to the "upper scale"?