Skip to content

Commit 70c0547

Browse files
authored
Fix spellcheck for benchmarking comments (paritytech#14535)
* Benchmarking spellcheck fix Put everything that could cause spellcheck issues into backticks. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Also in templates Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet-balances --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <>
1 parent 7aacdf1 commit 70c0547

4 files changed

Lines changed: 85 additions & 87 deletions

File tree

.maintain/frame-weight-template.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
//! DATE: {{date}}, STEPS: `{{cmd.steps}}`, REPEAT: `{{cmd.repeat}}`, LOW RANGE: `{{cmd.lowest_range_values}}`, HIGH RANGE: `{{cmd.highest_range_values}}`
66
//! WORST CASE MAP SIZE: `{{cmd.worst_case_map_values}}`
77
//! HOSTNAME: `{{hostname}}`, CPU: `{{cpuname}}`
8-
//! EXECUTION: {{cmd.execution}}, WASM-EXECUTION: {{cmd.wasm_execution}}, CHAIN: {{cmd.chain}}, DB CACHE: {{cmd.db_cache}}
8+
//! EXECUTION: `{{cmd.execution}}`, WASM-EXECUTION: `{{cmd.wasm_execution}}`, CHAIN: `{{cmd.chain}}`, DB CACHE: `{{cmd.db_cache}}`
99

1010
// Executed Command:
1111
{{#each args as |arg|}}
@@ -78,7 +78,7 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
7878
{{/each}}
7979
}
8080

81-
// For backwards compatibility and tests
81+
// For backwards compatibility and tests.
8282
impl WeightInfo for () {
8383
{{#each benchmarks as |benchmark|}}
8484
{{#each benchmark.comments as |comment|}}

frame/balances/src/weights.rs

Lines changed: 77 additions & 79 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

utils/frame/benchmarking-cli/src/pallet/template.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
//! DATE: {{date}}, STEPS: `{{cmd.steps}}`, REPEAT: `{{cmd.repeat}}`, LOW RANGE: `{{cmd.lowest_range_values}}`, HIGH RANGE: `{{cmd.highest_range_values}}`
66
//! WORST CASE MAP SIZE: `{{cmd.worst_case_map_values}}`
77
//! HOSTNAME: `{{hostname}}`, CPU: `{{cpuname}}`
8-
//! EXECUTION: {{cmd.execution}}, WASM-EXECUTION: {{cmd.wasm_execution}}, CHAIN: {{cmd.chain}}, DB CACHE: {{cmd.db_cache}}
8+
//! EXECUTION: `{{cmd.execution}}`, WASM-EXECUTION: `{{cmd.wasm_execution}}`, CHAIN: `{{cmd.chain}}`, DB CACHE: {{cmd.db_cache}}
99

1010
// Executed Command:
1111
{{#each args as |arg|}}

utils/frame/benchmarking-cli/src/pallet/writer.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,7 @@ pub(crate) fn process_storage_results(
666666
match key_info {
667667
Some(key_info) => {
668668
let comment = format!(
669-
"Storage: {} {} (r:{} w:{})",
669+
"Storage: `{}::{}` (r:{} w:{})",
670670
String::from_utf8(key_info.pallet_name.clone())
671671
.expect("encoded from string"),
672672
String::from_utf8(key_info.storage_name.clone())
@@ -678,7 +678,7 @@ pub(crate) fn process_storage_results(
678678
},
679679
None => {
680680
let comment = format!(
681-
"Storage: unknown `0x{}` (r:{} w:{})",
681+
"Storage: UNKNOWN KEY `0x{}` (r:{} w:{})",
682682
HexDisplay::from(key),
683683
reads,
684684
writes,
@@ -700,7 +700,7 @@ pub(crate) fn process_storage_results(
700700
) {
701701
Some(new_pov) => {
702702
let comment = format!(
703-
"Proof: {} {} (max_values: {:?}, max_size: {:?}, added: {}, mode: {:?})",
703+
"Proof: `{}::{}` (`max_values`: {:?}, `max_size`: {:?}, added: {}, mode: `{:?}`)",
704704
String::from_utf8(key_info.pallet_name.clone())
705705
.expect("encoded from string"),
706706
String::from_utf8(key_info.storage_name.clone())
@@ -718,7 +718,7 @@ pub(crate) fn process_storage_results(
718718
let item = String::from_utf8(key_info.storage_name.clone())
719719
.expect("encoded from string");
720720
let comment = format!(
721-
"Proof Skipped: {} {} (max_values: {:?}, max_size: {:?}, mode: {:?})",
721+
"Proof: `{}::{}` (`max_values`: {:?}, `max_size`: {:?}, mode: `{:?}`)",
722722
pallet, item, key_info.max_values, key_info.max_size,
723723
used_pov_mode,
724724
);
@@ -728,7 +728,7 @@ pub(crate) fn process_storage_results(
728728
},
729729
None => {
730730
let comment = format!(
731-
"Proof Skipped: unknown `0x{}` (r:{} w:{})",
731+
"Proof: UNKNOWN KEY `0x{}` (r:{} w:{})",
732732
HexDisplay::from(key),
733733
reads,
734734
writes,

0 commit comments

Comments
 (0)