refactor: reduce stop helper args for clippy

Author: zouyonghe

src-tauri/src/main.rs

@@ -2417,32 +2417,37 @@ fn log_status(label: &str, pid: u32, status: &io::Result<ExitStatus>) {
     }
 }
 
+struct StopCommandConfig<'a> {
+    max_followup: Duration,
+    label_graceful: &'a str,
+    label_force: &'a str,
+    subject: &'a str,
+}
+
 fn stop_child_process_impl(
     child: &mut Child,
     timeout: Duration,
     graceful_cmd: impl FnOnce(&str) -> Command,
     force_cmd: impl FnOnce(&str) -> Command,
-    max_followup: Duration,
-    label_graceful: &str,
-    label_force: &str,
-    subject: &str,
+    config: StopCommandConfig<'_>,
 ) -> bool {
     let pid = child.id();
     let pid_arg = pid.to_string();
 
     let graceful_status = graceful_cmd(pid_arg.as_str()).status();
-    log_status(label_graceful, pid, &graceful_status);
+    log_status(config.label_graceful, pid, &graceful_status);
 
     if wait_for_child_exit(child, timeout) {
         return true;
     }
 
     let force_status = force_cmd(pid_arg.as_str()).status();
-    log_status(label_force, pid, &force_status);
+    log_status(config.label_force, pid, &force_status);
 
-    let followup_wait = derive_force_stop_wait(timeout, max_followup);
+    let followup_wait = derive_force_stop_wait(timeout, config.max_followup);
     append_desktop_log(&format!(
-        "{subject} graceful stop timed out, force-kill issued: pid={pid}, graceful={graceful_status:?}, force={force_status:?}, followup_wait_ms={}",
+        "{} graceful stop timed out, force-kill issued: pid={pid}, graceful={graceful_status:?}, force={force_status:?}, followup_wait_ms={}",
+        config.subject,
         followup_wait.as_millis(),
     ));
     wait_for_child_exit(child, followup_wait)
@@ -2461,10 +2466,12 @@ fn stop_child_process_gracefully(child: &mut Child, timeout: Duration) -> bool {
         timeout,
         |pid_arg| build_stop_command("taskkill", &["/pid", pid_arg, "/t"]),
         |pid_arg| build_stop_command("taskkill", &["/pid", pid_arg, "/t", "/f"]),
-        Duration::from_millis(FORCE_STOP_WAIT_MAX_WINDOWS_MS),
-        "taskkill graceful stop",
-        "taskkill force stop",
-        "child",
+        StopCommandConfig {
+            max_followup: Duration::from_millis(FORCE_STOP_WAIT_MAX_WINDOWS_MS),
+            label_graceful: "taskkill graceful stop",
+            label_force: "taskkill force stop",
+            subject: "child",
+        },
     )
 }
 
@@ -2475,10 +2482,12 @@ fn stop_child_process_gracefully(child: &mut Child, timeout: Duration) -> bool {
         timeout,
         |pid_arg| build_stop_command("kill", &["-TERM", pid_arg]),
         |pid_arg| build_stop_command("kill", &["-KILL", pid_arg]),
-        Duration::from_millis(FORCE_STOP_WAIT_MAX_NON_WINDOWS_MS),
-        "kill -TERM",
-        "kill -KILL",
-        "child",
+        StopCommandConfig {
+            max_followup: Duration::from_millis(FORCE_STOP_WAIT_MAX_NON_WINDOWS_MS),
+            label_graceful: "kill -TERM",
+            label_force: "kill -KILL",
+            subject: "child",
+        },
     )
 }