Skip to content

Commit 732b1bd

Browse files
authored
fix(ci): suppress nightly generated release notes (#124)
1 parent d53f1e0 commit 732b1bd

2 files changed

Lines changed: 17 additions & 1 deletion

File tree

.github/workflows/build-desktop-tauri.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,7 @@ jobs:
687687
- Mode: `${{ needs.resolve_build_context.outputs.build_mode }}`
688688
- Windows package formats: `nsis installer` and `portable zip`.
689689
- Windows portable zip uses manual replacement updates and requires WebView2 to already exist on the host.
690-
generate_release_notes: true
690+
generate_release_notes: ${{ needs.resolve_build_context.outputs.build_mode != 'nightly' }}
691691
prerelease: ${{ needs.resolve_build_context.outputs.release_prerelease == 'true' }}
692692
make_latest: ${{ needs.resolve_build_context.outputs.release_make_latest == 'true' }}
693693
overwrite_files: true

scripts/ci/build-desktop-tauri-workflow.test.mjs

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import {
99

1010
const WORKFLOW_FILE = 'build-desktop-tauri.yml';
1111
const BUILD_MACOS_JOB = 'build-macos';
12+
const RELEASE_JOB = 'release';
1213
const PREPARE_RESOURCES_RUN = /pnpm run prepare:resources/;
1314
const PRESIGN_BACKEND_RUN = /codesign-macos-nested\.sh\s+"resources\/backend"/;
1415
const BUILD_APP_BUNDLE_RUN = /cargo tauri build --verbose --target/;
@@ -68,3 +69,18 @@ test('macOS workflow prepares resources before optional pre-signing', async () =
6869
/Resources are already prepared/,
6970
);
7071
});
72+
73+
test('release workflow disables generated release notes for nightly builds', async () => {
74+
const workflowObject = await readWorkflowObject(WORKFLOW_FILE);
75+
const steps = extractWorkflowJobSteps(workflowObject, RELEASE_JOB);
76+
const releaseStep = findStep(
77+
steps,
78+
'Create or update release',
79+
(step) => step.name === 'Create or update release' && /^softprops\/action-gh-release@/.test(step.uses ?? ''),
80+
);
81+
82+
assert.equal(
83+
releaseStep.with?.generate_release_notes,
84+
"${{ needs.resolve_build_context.outputs.build_mode != 'nightly' }}",
85+
);
86+
});

0 commit comments

Comments
 (0)