Skip to content

Commit f139563

Browse files
authored
Merge pull request #22 from zouyonghe/main
fix: stabilize desktop exit flow and refine CI release/version sync
2 parents bbfb06d + b48e4e6 commit f139563

3 files changed

Lines changed: 14 additions & 4 deletions

File tree

.github/workflows/build-desktop-tauri.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ on:
1515
description: Publish GitHub Release after successful builds
1616
required: false
1717
type: boolean
18-
default: false
18+
default: true
1919
schedule:
2020
- cron: '0 * * * *'
2121

@@ -192,7 +192,7 @@ jobs:
192192
needs:
193193
- resolve_build_context
194194
- sync_repo_version
195-
if: ${{ needs.resolve_build_context.outputs.should_build == 'true' && (needs.sync_repo_version.result == 'success' || needs.sync_repo_version.result == 'skipped') }}
195+
if: ${{ always() && needs.resolve_build_context.outputs.should_build == 'true' && (needs.sync_repo_version.result == 'success' || needs.sync_repo_version.result == 'skipped') }}
196196
name: linux-${{ matrix.arch }}
197197
runs-on: ${{ matrix.runner }}
198198
strategy:
@@ -243,7 +243,7 @@ jobs:
243243
needs:
244244
- resolve_build_context
245245
- sync_repo_version
246-
if: ${{ needs.resolve_build_context.outputs.should_build == 'true' && (needs.sync_repo_version.result == 'success' || needs.sync_repo_version.result == 'skipped') }}
246+
if: ${{ always() && needs.resolve_build_context.outputs.should_build == 'true' && (needs.sync_repo_version.result == 'success' || needs.sync_repo_version.result == 'skipped') }}
247247
name: macos-${{ matrix.arch }}
248248
runs-on: ${{ matrix.runner }}
249249
strategy:
@@ -414,7 +414,7 @@ jobs:
414414
needs:
415415
- resolve_build_context
416416
- sync_repo_version
417-
if: ${{ needs.resolve_build_context.outputs.should_build == 'true' && (needs.sync_repo_version.result == 'success' || needs.sync_repo_version.result == 'skipped') }}
417+
if: ${{ always() && needs.resolve_build_context.outputs.should_build == 'true' && (needs.sync_repo_version.result == 'success' || needs.sync_repo_version.result == 'skipped') }}
418418
name: windows-${{ matrix.arch }}
419419
runs-on: ${{ matrix.runner }}
420420
env:

Makefile

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,14 @@ dev:
7373
pnpm run dev
7474

7575
build:
76+
@set -e; \
77+
build_version="$(ASTRBOT_DESKTOP_VERSION)"; \
78+
if [ -z "$$build_version" ]; then \
79+
build_version="$$(node -e "console.log(require('./package.json').version)")"; \
80+
fi; \
81+
ASTRBOT_SOURCE_GIT_URL="$(ASTRBOT_SOURCE_GIT_URL)" \
82+
ASTRBOT_SOURCE_GIT_REF="$(ASTRBOT_SOURCE_GIT_REF)" \
83+
ASTRBOT_DESKTOP_VERSION="$$build_version" \
7684
pnpm run build
7785

7886
rebuild: clean build

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,8 @@ make prune
140140

141141
推荐日常使用 `make update`,避免本地切换分支导致版本漂移。
142142

143+
补充:`make build` 会默认使用当前 `package.json` 中的版本作为 `ASTRBOT_DESKTOP_VERSION`,避免构建前资源准备阶段把版本回写到其他值。若需覆盖,可显式传入 `ASTRBOT_DESKTOP_VERSION=...`
144+
143145
示例:
144146

145147
```bash

0 commit comments

Comments
 (0)