Skip to content

fix(ci): suppress nightly generated release notes #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zouyonghe merged 1 commit into from
Apr 28, 2026
Merged

fix(ci): suppress nightly generated release notes #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-desktop-tauri.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,7 @@ jobs:
- Mode: `${{ needs.resolve_build_context.outputs.build_mode }}`
- Windows package formats: `nsis installer` and `portable zip`.
- Windows portable zip uses manual replacement updates and requires WebView2 to already exist on the host.
generate_release_notes: true
generate_release_notes: ${{ needs.resolve_build_context.outputs.build_mode != 'nightly' }}
prerelease: ${{ needs.resolve_build_context.outputs.release_prerelease == 'true' }}
make_latest: ${{ needs.resolve_build_context.outputs.release_make_latest == 'true' }}
overwrite_files: true
Expand Down
16 changes: 16 additions & 0 deletions scripts/ci/build-desktop-tauri-workflow.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {

const WORKFLOW_FILE = 'build-desktop-tauri.yml';
const BUILD_MACOS_JOB = 'build-macos';
const RELEASE_JOB = 'release';
const PREPARE_RESOURCES_RUN = /pnpm run prepare:resources/;
const PRESIGN_BACKEND_RUN = /codesign-macos-nested\.sh\s+"resources\/backend"/;
const BUILD_APP_BUNDLE_RUN = /cargo tauri build --verbose --target/;
Expand Down Expand Up @@ -68,3 +69,18 @@ test('macOS workflow prepares resources before optional pre-signing', async () =
/Resources are already prepared/,
);
});

test('release workflow disables generated release notes for nightly builds', async () => {
const workflowObject = await readWorkflowObject(WORKFLOW_FILE);
const steps = extractWorkflowJobSteps(workflowObject, RELEASE_JOB);
const releaseStep = findStep(
steps,
'Create or update release',
(step) => step.name === 'Create or update release' && /^softprops\/action-gh-release@/.test(step.uses ?? ''),
);

assert.equal(
releaseStep.with?.generate_release_notes,
"${{ needs.resolve_build_context.outputs.build_mode != 'nightly' }}",
);
});