Skip to content

Commit 26ac634

Browse files
committed
fix: harden nightly release notes generation in workflow
1 parent f7bd130 commit 26ac634

1 file changed

Lines changed: 21 additions & 5 deletions

File tree

.github/workflows/release.yml

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,11 @@ jobs:
7474
default_branch="master"
7575
fi
7676
77-
if [ "$event_name" = "schedule" ] || { [ "$event_name" = "workflow_dispatch" ] && [ "$input_tag" = "$nightly_tag" ]; }; then
77+
if [ "$event_name" = "schedule" ]; then
78+
ref="refs/heads/${default_branch}"
79+
elif [ "$event_name" = "workflow_dispatch" ] && [ -n "$input_ref" ]; then
80+
ref="$input_ref"
81+
elif [ "$event_name" = "workflow_dispatch" ] && [ "$input_tag" = "$nightly_tag" ]; then
7882
ref="refs/heads/${default_branch}"
7983
elif [ -n "$input_ref" ]; then
8084
ref="$input_ref"
@@ -286,10 +290,22 @@ jobs:
286290
nightly_tag="${{ needs.resolve-release-context.outputs.nightly_tag }}"
287291
if [ "$tag" = "$nightly_tag" ]; then
288292
note_file="$(mktemp)"
289-
python3 scripts/release/generate_nightly_release_notes.py \
290-
--base-tag "${{ steps.release-meta.outputs.base_version }}" \
291-
--repo "${{ needs.resolve-release-context.outputs.repo_slug }}" \
292-
--output "$note_file"
293+
if [ -f "scripts/release/generate_nightly_release_notes.py" ]; then
294+
python3 scripts/release/generate_nightly_release_notes.py \
295+
--base-tag "${{ steps.release-meta.outputs.base_version }}" \
296+
--repo "${{ needs.resolve-release-context.outputs.repo_slug }}" \
297+
--output "$note_file"
298+
else
299+
short_sha="$(git rev-parse --short=8 HEAD)"
300+
echo "Nightly notes script is missing at this ref; using fallback notes."
301+
{
302+
echo "## What's Changed"
303+
echo ""
304+
echo "- Baseline tag: \`${{ steps.release-meta.outputs.base_version }}\`"
305+
echo "- Nightly commit: \`$short_sha\`"
306+
echo "- No changes summary generator available in this ref."
307+
} > "$note_file"
308+
fi
293309
else
294310
note_file="changelogs/${tag}.md"
295311
if [ ! -f "$note_file" ]; then

0 commit comments

Comments
 (0)