fix: refine extension preference sorting

Author: zouyonghe

dashboard/src/views/extension/extensionPreferenceStorage.mjs

@@ -2,7 +2,14 @@ export const SHOW_RESERVED_PLUGINS_STORAGE_KEY = "showReservedPlugins";
 export const PLUGIN_LIST_VIEW_MODE_STORAGE_KEY = "pluginListViewMode";
 export const PIN_UPDATES_ON_TOP_STORAGE_KEY = "pinUpdatesOnTop";
 
+/**
+ * Resolve the storage backend for preference helpers.
+ * Pass `null` to explicitly disable storage access in callers/tests.
+ */
 const resolveStorage = (storage) => {
+  if (storage === null) {
+    return null;
+  }
   if (storage !== undefined) {
     return storage;
   }

dashboard/src/views/extension/useExtensionPage.js

@@ -441,30 +441,35 @@ export const useExtensionPage = () => {
         installedAtTimestamp: getInstalledAtTimestamp(plugin),
       }))
       .sort((left, right) => {
-        const fallbackNameCompare = compareInstalledPluginNames(
-          left.plugin,
-          right.plugin,
-        );
-        const fallbackResult =
-          fallbackNameCompare !== 0 ? fallbackNameCompare : left.index - right.index;
-
         if (
           pinUpdatesOnTop.value &&
           installedSortBy.value !== "update_status"
         ) {
+          // Pinning updates is a primary grouping; the selected sort order still
+          // applies within the "has update" and "no update" groups below.
           const leftHasUpdate = left.plugin?.has_update ? 1 : 0;
           const rightHasUpdate = right.plugin?.has_update ? 1 : 0;
           if (leftHasUpdate !== rightHasUpdate) {
             return rightHasUpdate - leftHasUpdate;
           }
         }
 
+        const getFallbackResult = () => {
+          const fallbackNameCompare = compareInstalledPluginNames(
+            left.plugin,
+            right.plugin,
+          );
+          return fallbackNameCompare !== 0
+            ? fallbackNameCompare
+            : left.index - right.index;
+        };
+
         if (installedSortBy.value === "install_time") {
           const leftTimestamp = left.installedAtTimestamp;
           const rightTimestamp = right.installedAtTimestamp;
 
           if (leftTimestamp == null && rightTimestamp == null) {
-            return fallbackResult;
+            return getFallbackResult();
           }
           if (leftTimestamp == null) {
             return 1;
@@ -477,7 +482,7 @@ export const useExtensionPage = () => {
             installedSortOrder.value === "desc"
               ? rightTimestamp - leftTimestamp
               : leftTimestamp - rightTimestamp;
-          return timeDiff !== 0 ? timeDiff : fallbackResult;
+          return timeDiff !== 0 ? timeDiff : getFallbackResult();
         }
 
         if (installedSortBy.value === "name") {
@@ -500,7 +505,7 @@ export const useExtensionPage = () => {
               ? -authorCompare
               : authorCompare;
           }
-          return fallbackResult;
+          return getFallbackResult();
         }
 
         if (installedSortBy.value === "update_status") {
@@ -510,10 +515,10 @@ export const useExtensionPage = () => {
             installedSortOrder.value === "desc"
               ? rightHasUpdate - leftHasUpdate
               : leftHasUpdate - rightHasUpdate;
-          return updateDiff !== 0 ? updateDiff : fallbackResult;
+          return updateDiff !== 0 ? updateDiff : getFallbackResult();
         }
 
-        return fallbackResult;
+        return getFallbackResult();
       })
       .map((item) => item.plugin);
   };

dashboard/tests/extensionPreferenceStorage.test.mjs

@@ -33,6 +33,13 @@ test("readBooleanPreference parses stored boolean strings", () => {
   );
 });
 
+test("readBooleanPreference treats explicit null storage as unavailable", () => {
+  assert.equal(
+    readBooleanPreference(PIN_UPDATES_ON_TOP_STORAGE_KEY, true, null),
+    true,
+  );
+});
+
 test("writeBooleanPreference stores boolean strings and swallows storage errors", () => {
   const writes = [];
   const storage = {
@@ -47,3 +54,9 @@ test("writeBooleanPreference stores boolean strings and swallows storage errors"
   );
   assert.deepEqual(writes, [[PIN_UPDATES_ON_TOP_STORAGE_KEY, "true"]]);
 });
+
+test("writeBooleanPreference ignores explicit null storage", () => {
+  assert.doesNotThrow(() =>
+    writeBooleanPreference(PIN_UPDATES_ON_TOP_STORAGE_KEY, true, null),
+  );
+});