fix: resolve ASYNC230 and ASYNC240 without ignores

Author: zouyonghe

astrbot/core/agent/runners/coze/coze_api_client.py

@@ -2,6 +2,7 @@
 import io
 import json
 from collections.abc import AsyncGenerator
+from pathlib import Path
 from typing import Any
 
 import aiohttp
@@ -294,8 +295,7 @@ async def test_coze_api_client() -> None:
         client = CozeAPIClient(api_key=api_key)
 
         try:
-            with open("README.md", "rb") as f:
-                file_data = f.read()
+            file_data = await asyncio.to_thread(Path("README.md").read_bytes)
             file_id = await client.upload_file(file_data)
             print(f"Uploaded file_id: {file_id}")
             async for event in client.chat_messages(

astrbot/core/agent/runners/dify/dify_api_client.py

@@ -1,6 +1,8 @@
+import asyncio
 import codecs
 import json
 from collections.abc import AsyncGenerator
+from pathlib import Path
 from typing import Any
 
 from aiohttp import ClientResponse, ClientSession, FormData
@@ -134,14 +136,13 @@ async def file_upload(
             # 使用文件路径
             import os
 
-            with open(file_path, "rb") as f:
-                file_content = f.read()
-                form.add_field(
-                    "file",
-                    file_content,
-                    filename=os.path.basename(file_path),
-                    content_type=mime_type or "application/octet-stream",
-                )
+            file_content = await asyncio.to_thread(Path(file_path).read_bytes)
+            form.add_field(
+                "file",
+                file_content,
+                filename=os.path.basename(file_path),
+                content_type=mime_type or "application/octet-stream",
+            )
         else:
             raise ValueError("file_path 和 file_data 不能同时为 None")
 

astrbot/core/astr_agent_run_util.py

@@ -3,6 +3,7 @@
 import time
 import traceback
 from collections.abc import AsyncGenerator
+from pathlib import Path
 
 from astrbot.core import logger
 from astrbot.core.agent.message import Message
@@ -509,8 +510,7 @@ async def _simulated_stream_tts(
                 audio_path = await tts_provider.get_audio(text)
 
                 if audio_path:
-                    with open(audio_path, "rb") as f:
-                        audio_data = f.read()
+                    audio_data = await asyncio.to_thread(Path(audio_path).read_bytes)
                     await audio_queue.put((text, audio_data))
             except Exception as e:
                 logger.error(

astrbot/core/astr_main_agent_resources.py

@@ -1,3 +1,4 @@
+import asyncio
 import base64
 import json
 import os
@@ -241,7 +242,7 @@ async def _resolve_path_from_sandbox(
 
         bool: indicates whether the file was downloaded from sandbox.
         """
-        if os.path.exists(path):
+        if await asyncio.to_thread(os.path.exists, path):
             return path, False
 
         # Try to check if the file exists in the sandbox

astrbot/core/backup/exporter.py

@@ -4,6 +4,7 @@
 导出格式为 JSON，这是数据库无关的方案，支持未来向 MySQL/PostgreSQL 迁移。
 """
 
+import asyncio
 import hashlib
 import json
 import os
@@ -83,7 +84,7 @@ async def export_all(
             output_dir = get_astrbot_backups_path()
 
         # 确保输出目录存在
-        Path(output_dir).mkdir(parents=True, exist_ok=True)
+        await asyncio.to_thread(Path(output_dir).mkdir, parents=True, exist_ok=True)
 
         timestamp = datetime.now().strftime("%Y%m%d_%H%M%S")
         zip_filename = f"astrbot_backup_{timestamp}.zip"
@@ -160,9 +161,10 @@ async def export_all(
                 # 3. 导出配置文件
                 if progress_callback:
                     await progress_callback("config", 0, 100, "正在导出配置文件...")
-                if os.path.exists(self.config_path):
-                    with open(self.config_path, encoding="utf-8") as f:
-                        config_content = f.read()
+                if await asyncio.to_thread(os.path.exists, self.config_path):
+                    config_content = await asyncio.to_thread(
+                        Path(self.config_path).read_text, encoding="utf-8"
+                    )
                     zf.writestr("config/cmd_config.json", config_content)
                     self._add_checksum("config/cmd_config.json", config_content)
                 if progress_callback:
@@ -199,7 +201,7 @@ async def export_all(
         except Exception as e:
             logger.error(f"备份导出失败: {e}")
             # 清理失败的文件
-            if os.path.exists(zip_path):
+            if await asyncio.to_thread(os.path.exists, zip_path):
                 os.remove(zip_path)
             raise
 
@@ -317,7 +319,7 @@ async def _export_directories(
 
         for dir_name, dir_path in backup_directories.items():
             full_path = Path(dir_path)
-            if not full_path.exists():
+            if not await asyncio.to_thread(full_path.exists):
                 logger.debug(f"目录不存在，跳过: {full_path}")
                 continue
 
@@ -362,7 +364,7 @@ async def _export_attachments(
         for attachment in attachments:
             try:
                 file_path = attachment.get("path", "")
-                if file_path and os.path.exists(file_path):
+                if file_path and await asyncio.to_thread(os.path.exists, file_path):
                     # 使用 attachment_id 作为文件名
                     attachment_id = attachment.get("attachment_id", "")
                     ext = os.path.splitext(file_path)[1]

astrbot/core/backup/importer.py

@@ -7,6 +7,7 @@
 - 版本匹配时也需要用户确认
 """
 
+import asyncio
 import json
 import os
 import shutil
@@ -364,7 +365,7 @@ async def import_all(
         """
         result = ImportResult()
 
-        if not os.path.exists(zip_path):
+        if not await asyncio.to_thread(os.path.exists, zip_path):
             result.add_error(f"备份文件不存在: {zip_path}")
             return result
 
@@ -446,12 +447,13 @@ async def import_all(
                     try:
                         config_content = zf.read("config/cmd_config.json")
                         # 备份现有配置
-                        if os.path.exists(self.config_path):
+                        if await asyncio.to_thread(os.path.exists, self.config_path):
                             backup_path = f"{self.config_path}.bak"
                             shutil.copy2(self.config_path, backup_path)
 
-                        with open(self.config_path, "wb") as f:
-                            f.write(config_content)
+                        await asyncio.to_thread(
+                            Path(self.config_path).write_bytes, config_content
+                        )
                         result.imported_files["config"] = 1
                     except Exception as e:
                         result.add_warning(f"导入配置文件失败: {e}")
@@ -753,8 +755,8 @@ async def _import_knowledge_bases(
             if faiss_path in zf.namelist():
                 try:
                     target_path = kb_dir / "index.faiss"
-                    with zf.open(faiss_path) as src, open(target_path, "wb") as dst:
-                        dst.write(src.read())
+                    with zf.open(faiss_path) as src:
+                        await asyncio.to_thread(target_path.write_bytes, src.read())
                 except Exception as e:
                     result.add_warning(f"导入知识库 {kb_id} 的 FAISS 索引失败: {e}")
 
@@ -766,8 +768,8 @@ async def _import_knowledge_bases(
                         rel_path = name[len(media_prefix) :]
                         target_path = kb_dir / rel_path
                         target_path.parent.mkdir(parents=True, exist_ok=True)
-                        with zf.open(name) as src, open(target_path, "wb") as dst:
-                            dst.write(src.read())
+                        with zf.open(name) as src:
+                            await asyncio.to_thread(target_path.write_bytes, src.read())
                     except Exception as e:
                         result.add_warning(f"导入媒体文件 {name} 失败: {e}")
 
@@ -828,8 +830,8 @@ async def _import_attachments(
                         target_path = attachments_dir / os.path.basename(name)
 
                     target_path.parent.mkdir(parents=True, exist_ok=True)
-                    with zf.open(name) as src, open(target_path, "wb") as dst:
-                        dst.write(src.read())
+                    with zf.open(name) as src:
+                        await asyncio.to_thread(target_path.write_bytes, src.read())
                     count += 1
                 except Exception as e:
                     logger.warning(f"导入附件 {name} 失败: {e}")
@@ -885,15 +887,15 @@ async def _import_directories(
                     continue
 
                 # 备份现有目录（如果存在）
-                if target_dir.exists():
+                if await asyncio.to_thread(target_dir.exists):
                     backup_path = Path(f"{target_dir}.bak")
-                    if backup_path.exists():
+                    if await asyncio.to_thread(backup_path.exists):
                         shutil.rmtree(backup_path)
                     shutil.move(str(target_dir), str(backup_path))
                     logger.debug(f"已备份现有目录 {target_dir} 到 {backup_path}")
 
                 # 创建目标目录
-                target_dir.mkdir(parents=True, exist_ok=True)
+                await asyncio.to_thread(target_dir.mkdir, parents=True, exist_ok=True)
 
                 # 解压文件
                 for name in dir_files:
@@ -906,8 +908,8 @@ async def _import_directories(
                         target_path = target_dir / rel_path
                         target_path.parent.mkdir(parents=True, exist_ok=True)
 
-                        with zf.open(name) as src, open(target_path, "wb") as dst:
-                            dst.write(src.read())
+                        with zf.open(name) as src:
+                            await asyncio.to_thread(target_path.write_bytes, src.read())
                         file_count += 1
                     except Exception as e:
                         result.add_warning(f"导入文件 {name} 失败: {e}")

astrbot/core/computer/booters/boxlite.py

@@ -1,5 +1,6 @@
 import asyncio
 import random
+from pathlib import Path
 from typing import Any
 
 import aiohttp
@@ -46,8 +47,7 @@ async def upload_file(self, path: str, remote_path: str) -> dict:
 
         try:
             # Read file content
-            with open(path, "rb") as f:
-                file_content = f.read()
+            file_content = await asyncio.to_thread(Path(path).read_bytes)
 
             # Create multipart form data
             data = aiohttp.FormData()

astrbot/core/computer/booters/shipyard_neo.py

@@ -1,7 +1,9 @@
 from __future__ import annotations
 
+import asyncio
 import os
 import shlex
+from pathlib import Path
 from typing import Any, cast
 
 from astrbot.api import logger
@@ -468,8 +470,7 @@ def browser(self) -> BrowserComponent:
     async def upload_file(self, path: str, file_name: str) -> dict:
         if self._sandbox is None:
             raise RuntimeError("ShipyardNeoBooter is not initialized.")
-        with open(path, "rb") as f:
-            content = f.read()
+        content = await asyncio.to_thread(Path(path).read_bytes)
         remote_path = file_name.lstrip("/")
         await self._sandbox.filesystem.upload(remote_path, content)
         logger.info("[Computer] File uploaded to Neo sandbox: %s", remote_path)
@@ -486,8 +487,7 @@ async def download_file(self, remote_path: str, local_path: str) -> None:
         local_dir = os.path.dirname(local_path)
         if local_dir:
             os.makedirs(local_dir, exist_ok=True)
-        with open(local_path, "wb") as f:
-            f.write(cast(bytes, content))
+        await asyncio.to_thread(Path(local_path).write_bytes, cast(bytes, content))
         logger.info(
             "[Computer] File downloaded from Neo sandbox: %s -> %s",
             remote_path,

astrbot/core/computer/computer_client.py

@@ -1,3 +1,4 @@
+import asyncio
 import json
 import os
 import shutil
@@ -372,12 +373,12 @@ async def _sync_skills_to_sandbox(booter: ComputerBooter) -> None:
     splitting into `apply` and `scan` phases.
     """
     skills_root = Path(get_astrbot_skills_path())
-    if not skills_root.is_dir():
+    if not await asyncio.to_thread(skills_root.is_dir):
         return
     local_skill_dirs = _list_local_skill_dirs(skills_root)
 
     temp_dir = Path(get_astrbot_temp_path())
-    temp_dir.mkdir(parents=True, exist_ok=True)
+    await asyncio.to_thread(temp_dir.mkdir, parents=True, exist_ok=True)
     zip_base = temp_dir / "skills_bundle"
     zip_path = zip_base.with_suffix(".zip")
 

astrbot/core/computer/tools/fs.py

@@ -1,3 +1,4 @@
+import asyncio
 import os
 import uuid
 from dataclasses import dataclass, field
@@ -111,10 +112,10 @@ async def call(
         )
         try:
             # Check if file exists
-            if not os.path.exists(local_path):
+            if not await asyncio.to_thread(os.path.exists, local_path):
                 return f"Error: File does not exist: {local_path}"
 
-            if not os.path.isfile(local_path):
+            if not await asyncio.to_thread(os.path.isfile, local_path):
                 return f"Error: Path is not a file: {local_path}"
 
             # Use basename if sandbox_filename is not provided