refactor: improve failed plugin diagnostics and uninstall flow

Author: zouyonghe

astrbot/core/star/star_manager.py

@@ -461,9 +461,19 @@ def _rebuild_failed_plugin_info(self) -> None:
         for dir_name, info in self.failed_plugin_dict.items():
             if isinstance(info, dict):
                 error = info.get("error", "未知错误")
+                display_name = info.get("display_name") or info.get("name") or dir_name
+                version = info.get("version") or info.get("astrbot_version")
+                if version:
+                    lines.append(
+                        f"加载插件「{display_name}」(目录: {dir_name}, 版本: {version}) 时出现问题，原因：{error}。",
+                    )
+                else:
+                    lines.append(
+                        f"加载插件「{display_name}」(目录: {dir_name}) 时出现问题，原因：{error}。",
+                    )
             else:
                 error = str(info)
-            lines.append(f"加载 {dir_name} 插件时出现问题，原因 {error}。")
+                lines.append(f"加载插件目录 {dir_name} 时出现问题，原因：{error}。")
 
         self.failed_plugin_info = "\n".join(lines) + "\n"
 

dashboard/src/views/extension/useExtensionPage.js

@@ -509,90 +509,113 @@ export const useExtensionPage = () => {
       }
   };
 
+  const showReloadFeedback = (message, type) => {
+    clearReloadFeedback();
+    setReloadFeedback(message, type);
+    toast(message, type === "success" ? "success" : "error");
+  };
+
   const reloadFailedPlugin = async (dirName) => {
-    // Reset stale inline feedback before each retry attempt
+    if (!dirName) return;
     clearReloadFeedback();
 
-    if (!dirName) {
-      return;
-    }
     try {
       const res = await axios.post("/api/plugin/reload-failed", { dir_name: dirName });
       if (res.data.status === "error") {
-        const message = res.data.message || tm("messages.reloadFailed");
-        setReloadFeedback(message, "error");
-        toast(message, "error");
+        showReloadFeedback(res.data.message || tm("messages.reloadFailed"), "error");
         return;
       }
-      setReloadFeedback(res.data.message || tm("messages.reloadSuccess"), "success");
+      showReloadFeedback(res.data.message || tm("messages.reloadSuccess"), "success");
       await getExtensions();
     } catch (err) {
-      const message = resolveErrorMessage(err, tm("messages.reloadFailed"));
-      setReloadFeedback(message, "error");
-      toast(message, "error");
+      showReloadFeedback(
+        resolveErrorMessage(err, tm("messages.reloadFailed")),
+        "error",
+      );
     }
   };
 
-  const requestUninstall = (kind, id) => {
-    if (!id) return;
-    uninstallTarget.value = { kind, id };
+  const openUninstallDialog = (target) => {
+    if (!target?.id) return;
+    uninstallTarget.value = target;
     showUninstallDialog.value = true;
   };
 
-  const requestUninstallPlugin = (name) => {
-    requestUninstall("normal", name);
-  };
-
-  const requestUninstallFailedPlugin = (dirName) => {
-    requestUninstall("failed", dirName);
-  };
-
-  const performUninstall = async (target, options = {}) => {
-    if (!target?.id) return;
-
-    const { deleteConfig = false, deleteData = false } = options || {};
-    toast(`${tm("messages.uninstalling")} ${target.id}`, "primary");
-
+  const doUninstallNormal = async (
+    name,
+    { deleteConfig = false, deleteData = false } = {},
+  ) => {
+    toast(`${tm("messages.uninstalling")} ${name}`, "primary");
     try {
-      if (target.kind === "failed") {
-        const res = await axios.post("/api/plugin/uninstall-failed", {
-          dir_name: target.id,
-          delete_config: deleteConfig,
-          delete_data: deleteData,
-        });
-        if (res.data.status === "error") {
-          toast(res.data.message, "error");
-          return;
-        }
-        toast(res.data.message, "success");
-        await getExtensions();
+      const res = await axios.post("/api/plugin/uninstall", {
+        name,
+        delete_config: deleteConfig,
+        delete_data: deleteData,
+      });
+      if (res.data.status === "error") {
+        toast(res.data.message, "error");
         return;
       }
+      Object.assign(extension_data, res.data);
+      toast(res.data.message, "success");
+      await getExtensions();
+    } catch (err) {
+      toast(resolveErrorMessage(err), "error");
+    }
+  };
 
-      const res = await axios.post("/api/plugin/uninstall", {
-        name: target.id,
+  const doUninstallFailed = async (
+    dirName,
+    { deleteConfig = false, deleteData = false } = {},
+  ) => {
+    toast(`${tm("messages.uninstalling")} ${dirName}`, "primary");
+    try {
+      const res = await axios.post("/api/plugin/uninstall-failed", {
+        dir_name: dirName,
         delete_config: deleteConfig,
         delete_data: deleteData,
       });
       if (res.data.status === "error") {
         toast(res.data.message, "error");
         return;
       }
-      Object.assign(extension_data, res.data);
       toast(res.data.message, "success");
       await getExtensions();
     } catch (err) {
       toast(resolveErrorMessage(err), "error");
     }
   };
 
-  const uninstallFailedPlugin = async (dirName, options = null) => {
+  const uninstallNormalPlugin = async (
+    name,
+    { skipConfirm = false, ...options } = {},
+  ) => {
+    if (!name) return;
+    if (!skipConfirm) {
+      openUninstallDialog({ kind: "normal", id: name });
+      return;
+    }
+    await doUninstallNormal(name, options);
+  };
+
+  const uninstallFailedPlugin = async (
+    dirName,
+    { skipConfirm = false, ...options } = {},
+  ) => {
     if (!dirName) return;
-    if (!options || typeof options !== "object") {
-      requestUninstallFailedPlugin(dirName);
+    if (!skipConfirm) {
+      openUninstallDialog({ kind: "failed", id: dirName });
       return;
     }
-    await performUninstall({ kind: "failed", id: dirName }, options);
+    await doUninstallFailed(dirName, options);
+  };
+
+  const requestUninstallPlugin = (name) => {
+    uninstallNormalPlugin(name);
+  };
+
+  const requestUninstallFailedPlugin = (dirName) => {
+    uninstallFailedPlugin(dirName);
   };
 
   const checkUpdate = () => {
@@ -624,23 +647,13 @@ export const useExtensionPage = () => {
     });
   };
 
-  const uninstallExtension = async (extensionName, optionsOrSkipConfirm = false) => {
+  const uninstallExtension = async (extensionName, options = null) => {
     if (!extensionName) return;
-
-    if (typeof optionsOrSkipConfirm === "boolean") {
-      if (!optionsOrSkipConfirm) {
-        requestUninstallPlugin(extensionName);
-        return;
-      }
-      await performUninstall({ kind: "normal", id: extensionName });
+    if (options && typeof options === "object") {
+      await uninstallNormalPlugin(extensionName, { ...options, skipConfirm: true });
       return;
     }
-
-    const options =
-      typeof optionsOrSkipConfirm === "object" && optionsOrSkipConfirm !== null
-        ? optionsOrSkipConfirm
-        : {};
-    await performUninstall({ kind: "normal", id: extensionName }, options);
+    await uninstallNormalPlugin(extensionName);
   };
 
   // 处理卸载确认对话框的确认事件
@@ -649,7 +662,11 @@ export const useExtensionPage = () => {
     if (!target) return;
 
     try {
-      await performUninstall(target, options);
+      if (target.kind === "normal") {
+        await doUninstallNormal(target.id, options);
+      } else {
+        await doUninstallFailed(target.id, options);
+      }
     } finally {
       uninstallTarget.value = null;
       showUninstallDialog.value = false;