fix: avoid blocking file read in file_to_base64

Author: zouyonghe

astrbot/core/message/components.py

@@ -183,14 +183,14 @@ async def convert_to_base64(self) -> str:
         if not self.file:
             raise Exception(f"not a valid file: {self.file}")
         if self.file.startswith("file:///"):
-            bs64_data = file_to_base64(self.file[8:])
+            bs64_data = await file_to_base64(self.file[8:])
         elif self.file.startswith("http"):
             file_path = await download_image_by_url(self.file)
-            bs64_data = file_to_base64(file_path)
+            bs64_data = await file_to_base64(file_path)
         elif self.file.startswith("base64://"):
             bs64_data = self.file
         elif await asyncio.to_thread(os.path.exists, self.file):
-            bs64_data = file_to_base64(self.file)
+            bs64_data = await file_to_base64(self.file)
         else:
             raise Exception(f"not a valid file: {self.file}")
         bs64_data = bs64_data.removeprefix("base64://")
@@ -474,14 +474,14 @@ async def convert_to_base64(self) -> str:
         if not url:
             raise ValueError("No valid file or URL provided")
         if url.startswith("file:///"):
-            bs64_data = file_to_base64(url[8:])
+            bs64_data = await file_to_base64(url[8:])
         elif url.startswith("http"):
             image_file_path = await download_image_by_url(url)
-            bs64_data = file_to_base64(image_file_path)
+            bs64_data = await file_to_base64(image_file_path)
         elif url.startswith("base64://"):
             bs64_data = url
         elif await asyncio.to_thread(os.path.exists, url):
-            bs64_data = file_to_base64(url)
+            bs64_data = await file_to_base64(url)
         else:
             raise Exception(f"not a valid file: {url}")
         bs64_data = bs64_data.removeprefix("base64://")

astrbot/core/platform/sources/qqofficial/qqofficial_message_event.py

@@ -421,15 +421,15 @@ async def _parse_to_qqofficial(message: MessageChain):
                 plain_text += i.text
             elif isinstance(i, Image) and not image_base64:
                 if i.file and i.file.startswith("file:///"):
-                    image_base64 = file_to_base64(i.file[8:])
+                    image_base64 = await file_to_base64(i.file[8:])
                     image_file_path = i.file[8:]
                 elif i.file and i.file.startswith("http"):
                     image_file_path = await download_image_by_url(i.file)
-                    image_base64 = file_to_base64(image_file_path)
+                    image_base64 = await file_to_base64(image_file_path)
                 elif i.file and i.file.startswith("base64://"):
                     image_base64 = i.file
                 elif i.file:
-                    image_base64 = file_to_base64(i.file)
+                    image_base64 = await file_to_base64(i.file)
                 else:
                     raise ValueError("Unsupported image file format")
                 image_base64 = image_base64.removeprefix("base64://")

astrbot/core/utils/io.py

@@ -201,8 +201,8 @@ async def download_file(url: str, path: str, show_progress: bool = False) -> Non
         print()
 
 
-def file_to_base64(file_path: str) -> str:
-    data_bytes = Path(file_path).read_bytes()
+async def file_to_base64(file_path: str) -> str:
+    data_bytes = await asyncio.to_thread(Path(file_path).read_bytes)
     base64_str = base64.b64encode(data_bytes).decode()
     return "base64://" + base64_str
 

tests/unit/test_io_file_to_base64.py

@@ -0,0 +1,16 @@
+import base64
+
+import pytest
+
+from astrbot.core.utils.io import file_to_base64
+
+
+@pytest.mark.asyncio
+async def test_file_to_base64_reads_file_async(tmp_path):
+    sample_file = tmp_path / "sample.bin"
+    sample_file.write_bytes(b"astrbot")
+
+    result = await file_to_base64(str(sample_file))
+
+    expected = "base64://" + base64.b64encode(b"astrbot").decode()
+    assert result == expected