fix: address async io review feedback

Author: zouyonghe

astrbot/core/backup/exporter.py

@@ -368,20 +368,22 @@ def _export_attachments_sync(
     ) -> None:
         """在单个线程中批量导出附件，减少高频线程切换。"""
         for attachment in attachments:
+            file_path = attachment.get("path", "")
+            attachment_id = attachment.get("attachment_id", "")
             try:
-                file_path = attachment.get("path", "")
                 if not file_path:
                     continue
                 # 使用 attachment_id 作为文件名
-                attachment_id = attachment.get("attachment_id", "")
                 ext = os.path.splitext(file_path)[1]
                 archive_path = f"files/attachments/{attachment_id}{ext}"
                 zf.write(file_path, archive_path)
             except FileNotFoundError:
                 # 和旧逻辑保持一致：缺失文件直接跳过。
                 continue
-            except Exception as e:
-                logger.warning(f"导出附件失败: {e}")
+            except OSError as e:
+                logger.warning(
+                    f"导出附件失败 (path={file_path}, attachment_id={attachment_id or 'unknown'}): {e}"
+                )
 
     def _read_text_if_exists(self, file_path: str) -> str | None:
         """Read text file when it exists in a single synchronous call."""

astrbot/core/utils/io.py

@@ -9,6 +9,7 @@
 import uuid
 import zipfile
 from pathlib import Path
+from typing import BinaryIO
 
 import aiohttp
 import certifi
@@ -185,18 +186,18 @@ async def download_file(url: str, path: str, show_progress: bool = False) -> Non
 
 async def _stream_to_file(
     stream: aiohttp.StreamReader,
-    file_obj,
+    file_obj: BinaryIO,
     *,
     total_size: int,
     start_time: float,
     show_progress: bool,
     chunk_size: int = 8192,
     flush_threshold: int = 256 * 1024,
-) -> int:
+) -> None:
     """Stream HTTP response into file with buffered thread-offloaded writes."""
     downloaded_size = 0
     buffered = bytearray()
-    progress_total = max(total_size, 1)
+    progress_total = total_size if total_size > 0 else None
 
     while True:
         chunk = await stream.read(chunk_size)
@@ -213,16 +214,21 @@ async def _stream_to_file(
         if show_progress:
             elapsed_time = max(time.time() - start_time, 1e-6)
             speed = downloaded_size / 1024 / elapsed_time  # KB/s
-            print(
-                f"\r下载进度: {downloaded_size / progress_total:.2%} 速度: {speed:.2f} KB/s",
-                end="",
-            )
+            if progress_total:
+                percent = downloaded_size / progress_total
+                print(
+                    f"\r下载进度: {percent:.2%} 速度: {speed:.2f} KB/s",
+                    end="",
+                )
+            else:
+                print(
+                    f"\r已下载: {downloaded_size} 字节 速度: {speed:.2f} KB/s",
+                    end="",
+                )
 
     if buffered:
         await asyncio.to_thread(file_obj.write, bytes(buffered))
 
-    return downloaded_size
-
 
 async def file_to_base64(file_path: str) -> str:
     data_bytes = await asyncio.to_thread(Path(file_path).read_bytes)

tests/unit/test_message_components_paths.py

@@ -1,3 +1,4 @@
+import base64
 import os
 
 import pytest
@@ -52,3 +53,27 @@ async def test_record_convert_to_base64_raises_on_missing_file(tmp_path):
 
     with pytest.raises(Exception, match="not a valid file"):
         await record.convert_to_base64()
+
+
+@pytest.mark.asyncio
+async def test_image_convert_to_base64_reads_existing_local_file(tmp_path):
+    raw = b"image-bytes"
+    file_path = tmp_path / "exists_image.bin"
+    file_path.write_bytes(raw)
+
+    image = Image(file=str(file_path))
+    encoded = await image.convert_to_base64()
+
+    assert base64.b64decode(encoded) == raw
+
+
+@pytest.mark.asyncio
+async def test_record_convert_to_base64_reads_existing_local_file(tmp_path):
+    raw = b"record-bytes"
+    file_path = tmp_path / "exists_record.bin"
+    file_path.write_bytes(raw)
+
+    record = Record(file=str(file_path))
+    encoded = await record.convert_to_base64()
+
+    assert base64.b64decode(encoded) == raw