fix: harden extension preference storage

Author: zouyonghe

dashboard/src/views/extension/extensionPreferenceStorage.mjs

@@ -0,0 +1,50 @@
+export const SHOW_RESERVED_PLUGINS_STORAGE_KEY = "showReservedPlugins";
+export const PLUGIN_LIST_VIEW_MODE_STORAGE_KEY = "pluginListViewMode";
+export const PIN_UPDATES_ON_TOP_STORAGE_KEY = "pinUpdatesOnTop";
+
+const resolveStorage = (storage) => {
+  if (storage !== undefined) {
+    return storage;
+  }
+  if (typeof window === "undefined") {
+    return null;
+  }
+  try {
+    return window.localStorage ?? null;
+  } catch {
+    return null;
+  }
+};
+
+export const readBooleanPreference = (key, fallback, storage) => {
+  const targetStorage = resolveStorage(storage);
+  if (!targetStorage) {
+    return fallback;
+  }
+
+  try {
+    const saved = targetStorage.getItem(key);
+    if (saved === "true") {
+      return true;
+    }
+    if (saved === "false") {
+      return false;
+    }
+    return fallback;
+  } catch {
+    return fallback;
+  }
+};
+
+export const writeBooleanPreference = (key, value, storage) => {
+  const targetStorage = resolveStorage(storage);
+  if (!targetStorage) {
+    return;
+  }
+
+  try {
+    targetStorage.setItem(key, String(value));
+  } catch {
+    // Ignore restricted storage environments.
+  }
+};

dashboard/src/views/extension/useExtensionPage.js

@@ -14,6 +14,13 @@ import {
   getValidHashTab,
   replaceTabRoute,
 } from "@/utils/hashRouteTabs.mjs";
+import {
+  PIN_UPDATES_ON_TOP_STORAGE_KEY,
+  PLUGIN_LIST_VIEW_MODE_STORAGE_KEY,
+  SHOW_RESERVED_PLUGINS_STORAGE_KEY,
+  readBooleanPreference,
+  writeBooleanPreference,
+} from "./extensionPreferenceStorage.mjs";
 import { ref, computed, onMounted, onUnmounted, reactive, watch } from "vue";
 import { useRoute, useRouter } from "vue-router";
 import { useDisplay } from "vuetify";
@@ -124,11 +131,7 @@ export const useExtensionPage = () => {
 
   // 从 localStorage 恢复显示系统插件的状态，默认为 false（隐藏）
   const getInitialShowReserved = () => {
-    if (typeof window !== "undefined" && window.localStorage) {
-      const saved = localStorage.getItem("showReservedPlugins");
-      return saved === "true";
-    }
-    return false;
+    return readBooleanPreference(SHOW_RESERVED_PLUGINS_STORAGE_KEY, false);
   };
   const showReserved = ref(getInitialShowReserved());
   const snack_message = ref("");
@@ -178,28 +181,19 @@ export const useExtensionPage = () => {
   // 新增变量支持列表视图
   // 从 localStorage 恢复显示模式，默认为 false（卡片视图）
   const getInitialListViewMode = () => {
-    if (typeof window !== "undefined" && window.localStorage) {
-      return localStorage.getItem("pluginListViewMode") === "true";
-    }
-    return false;
+    return readBooleanPreference(PLUGIN_LIST_VIEW_MODE_STORAGE_KEY, false);
   };
   const isListView = ref(getInitialListViewMode());
   const pluginSearch = ref("");
   const installedStatusFilter = ref("all");
   const installedSortBy = ref("default");
   const installedSortOrder = ref("desc");
   const getInitialPinUpdatesOnTop = () => {
-    if (typeof window !== "undefined" && window.localStorage) {
-      const saved = localStorage.getItem("pinUpdatesOnTop");
-      return saved !== "false";
-    }
-    return true;
+    return readBooleanPreference(PIN_UPDATES_ON_TOP_STORAGE_KEY, true);
   };
   const pinUpdatesOnTop = ref(getInitialPinUpdatesOnTop());
   watch(pinUpdatesOnTop, (val) => {
-    if (typeof window !== "undefined" && window.localStorage) {
-      localStorage.setItem("pinUpdatesOnTop", val.toString());
-    }
+    writeBooleanPreference(PIN_UPDATES_ON_TOP_STORAGE_KEY, val);
   });
   const loading_ = ref(false);
 
@@ -660,9 +654,7 @@ export const useExtensionPage = () => {
   const toggleShowReserved = () => {
     showReserved.value = !showReserved.value;
     // 保存到 localStorage
-    if (typeof window !== "undefined" && window.localStorage) {
-      localStorage.setItem("showReservedPlugins", showReserved.value.toString());
-    }
+    writeBooleanPreference(SHOW_RESERVED_PLUGINS_STORAGE_KEY, showReserved.value);
   };
 
   const toast = (message, success) => {
@@ -1627,9 +1619,7 @@ export const useExtensionPage = () => {
 
   // 监听显示模式变化并保存到 localStorage
   watch(isListView, (newVal) => {
-    if (typeof window !== "undefined" && window.localStorage) {
-      localStorage.setItem("pluginListViewMode", String(newVal));
-    }
+    writeBooleanPreference(PLUGIN_LIST_VIEW_MODE_STORAGE_KEY, newVal);
   });
 
   watch(

dashboard/tests/extensionPreferenceStorage.test.mjs

@@ -0,0 +1,49 @@
+import test from 'node:test';
+import assert from 'node:assert/strict';
+
+import {
+  PIN_UPDATES_ON_TOP_STORAGE_KEY,
+  readBooleanPreference,
+  writeBooleanPreference,
+} from '../src/views/extension/extensionPreferenceStorage.mjs';
+
+test("readBooleanPreference returns fallback when storage access throws", () => {
+  const storage = {
+    getItem() {
+      throw new Error("SecurityError");
+    },
+  };
+
+  assert.equal(
+    readBooleanPreference(PIN_UPDATES_ON_TOP_STORAGE_KEY, true, storage),
+    true,
+  );
+});
+
+test("readBooleanPreference parses stored boolean strings", () => {
+  const storage = {
+    getItem(key) {
+      return key === PIN_UPDATES_ON_TOP_STORAGE_KEY ? "false" : null;
+    },
+  };
+
+  assert.equal(
+    readBooleanPreference(PIN_UPDATES_ON_TOP_STORAGE_KEY, true, storage),
+    false,
+  );
+});
+
+test("writeBooleanPreference stores boolean strings and swallows storage errors", () => {
+  const writes = [];
+  const storage = {
+    setItem(key, value) {
+      writes.push([key, value]);
+      throw new Error("QuotaExceededError");
+    },
+  };
+
+  assert.doesNotThrow(() =>
+    writeBooleanPreference(PIN_UPDATES_ON_TOP_STORAGE_KEY, true, storage),
+  );
+  assert.deepEqual(writes, [[PIN_UPDATES_ON_TOP_STORAGE_KEY, "true"]]);
+});