refactor(discord): use typed constructor argument for allow_bot_messages

Address code review feedback:
- Add `allow_bot_messages` as a typed constructor argument in DiscordBotClient
- Simplify the on_message check by using the instance attribute directly
- Pass the parameter in constructor instead of using setattr

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

astrbot/core/platform/sources/discord/client.py

@@ -15,9 +15,12 @@
 class DiscordBotClient(discord.Bot):
     """Discord客户端封装"""
 
-    def __init__(self, token: str, proxy: str | None = None) -> None:
+    def __init__(
+        self, token: str, proxy: str | None = None, allow_bot_messages: bool = False
+    ) -> None:
         self.token = token
         self.proxy = proxy
+        self.allow_bot_messages = allow_bot_messages
 
         # 设置Intent权限，遵循权限最小化原则
         intents = discord.Intents.default()
@@ -95,9 +98,7 @@ def _create_interaction_data(self, interaction: discord.Interaction) -> dict:
 
     async def on_message(self, message: discord.Message) -> None:
         """当接收到消息时触发"""
-        # 如果配置不允许接收 bot 的消息，则忽略 bot 消息（向后兼容原行为）
-        allow_bots = getattr(self, "allow_bot_messages", False)
-        if message.author.bot and not allow_bots:
+        if message.author.bot and not self.allow_bot_messages:
             return
 
         logger.debug(

astrbot/core/platform/sources/discord/discord_platform_adapter.py

@@ -140,10 +140,8 @@ async def on_received(message_data) -> None:
             return
 
         proxy = self.config.get("discord_proxy") or None
-        self.client = DiscordBotClient(token, proxy)
-        # 从配置读取是否允许接收其他 bot 的消息
         allow_bot_messages = bool(self.config.get("discord_allow_bot_messages"))
-        setattr(self.client, "allow_bot_messages", allow_bot_messages)
+        self.client = DiscordBotClient(token, proxy, allow_bot_messages)
         self.client.on_message_received = on_received
 
         async def callback() -> None: