Skip to content

fix(webui): keep account dialog content scrollable#6975

Closed
1zzxy1 wants to merge 2 commits intoAstrBotDevs:masterfrom
1zzxy1:fix/account-dialog-scroll
Closed

fix(webui): keep account dialog content scrollable#6975
1zzxy1 wants to merge 2 commits intoAstrBotDevs:masterfrom
1zzxy1:fix/account-dialog-scroll

Conversation

@1zzxy1
Copy link
Copy Markdown
Contributor

@1zzxy1 1zzxy1 commented Mar 26, 2026

Summary

  • keep the account dialog content scrollable on smaller windows
  • prevent the confirm-password and action area from being pushed out of view during forced first-login password changes
  • limit the fix to dialog layout only without changing account edit validation logic

Fixes #6628

Testing

  • git diff --check
  • frontend build/lint not run locally in this environment (dashboard dependencies/pnpm unavailable)

Summary by Sourcery

Ensure the account dialog layout remains scrollable and usable on smaller viewports without altering validation behavior.

Enhancements:

  • Constrain the account dialog card height and layout to fit within the viewport while keeping critical actions visible.
  • Make the account dialog content area independently scrollable to prevent form fields and buttons from being pushed out of view on small screens.

@auto-assign auto-assign Bot requested review from advent259141 and anka-afk March 26, 2026 02:40
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 26, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience of the account dialog by addressing responsiveness issues. It ensures that the dialog's content remains fully accessible and scrollable, particularly on smaller screens and during specific password change workflows, without impacting existing validation logic.

Highlights

  • Responsive UI: The account dialog content now remains scrollable on smaller windows, improving usability on various screen sizes.
  • User Experience: The confirm-password and action areas are prevented from being pushed out of view during forced first-login password changes, ensuring critical elements are always accessible.
  • Scope Limitation: The fix is strictly limited to the dialog's layout and does not alter any account edit validation logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding flex: 1 1 auto (or at least flex: 1) to .account-dialog__content so the scrollable area reliably takes up the remaining space inside the flex .account-dialog card, preventing layout issues if additional sections (e.g., actions/footer) are added.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding `flex: 1 1 auto` (or at least `flex: 1`) to `.account-dialog__content` so the scrollable area reliably takes up the remaining space inside the flex `.account-dialog` card, preventing layout issues if additional sections (e.g., actions/footer) are added.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dosubot dosubot Bot added the area:webui The bug / feature is about webui(dashboard) of astrbot. label Mar 26, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the account dialog's styling in VerticalHeader.vue to manage its maximum height and enable vertical scrolling for its content. The feedback suggests improving maintainability by replacing the hardcoded 760px max-height value with a CSS variable or design token.

}

.account-dialog {
max-height: min(90vh, 760px);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The 760px value used for max-height is a magic number. For better maintainability and consistency, consider defining such fixed dimensions as CSS variables or design tokens, especially if this value is part of a broader design system or might be reused. This makes it easier to manage and update UI dimensions centrally.

@Soulter Soulter closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webui The bug / feature is about webui(dashboard) of astrbot. size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]4.20.1 docker部署之后的登录页面提示“两次输入的新密码不一致”

2 participants