fix(webui): keep account dialog content scrollable#6975
fix(webui): keep account dialog content scrollable#69751zzxy1 wants to merge 2 commits intoAstrBotDevs:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience of the account dialog by addressing responsiveness issues. It ensures that the dialog's content remains fully accessible and scrollable, particularly on smaller screens and during specific password change workflows, without impacting existing validation logic. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding
flex: 1 1 auto(or at leastflex: 1) to.account-dialog__contentso the scrollable area reliably takes up the remaining space inside the flex.account-dialogcard, preventing layout issues if additional sections (e.g., actions/footer) are added.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding `flex: 1 1 auto` (or at least `flex: 1`) to `.account-dialog__content` so the scrollable area reliably takes up the remaining space inside the flex `.account-dialog` card, preventing layout issues if additional sections (e.g., actions/footer) are added.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request refactors the account dialog's styling in VerticalHeader.vue to manage its maximum height and enable vertical scrolling for its content. The feedback suggests improving maintainability by replacing the hardcoded 760px max-height value with a CSS variable or design token.
| } | ||
|
|
||
| .account-dialog { | ||
| max-height: min(90vh, 760px); |
There was a problem hiding this comment.
The 760px value used for max-height is a magic number. For better maintainability and consistency, consider defining such fixed dimensions as CSS variables or design tokens, especially if this value is part of a broader design system or might be reused. This makes it easier to manage and update UI dimensions centrally.
Summary
Fixes #6628
Testing
Summary by Sourcery
Ensure the account dialog layout remains scrollable and usable on smaller viewports without altering validation behavior.
Enhancements: