Skip to content

fix(webui): keep account dialog content scrollable #6975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1zzxy1 wants to merge 2 commits into from
Closed

fix(webui): keep account dialog content scrollable #6975

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38e9696
fix(webui): keep account dialog content scrollable
1zzxy1 Mar 26, 2026
81dbaca
fix(webui): let account dialog body grow in flex layout
1zzxy1 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion dashboard/src/layouts/full/vertical-header/VerticalHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,7 +824,7 @@ onMounted(async () => {
<!-- 账户对话框 -->
<v-dialog v-model="dialog" persistent :max-width="$vuetify.display.xs ? '90%' : '500'">
<v-card class="account-dialog">
<v-card-text class="py-6">
<v-card-text class="account-dialog__content py-6">
<div class="d-flex flex-column align-center mb-6">
<logo :title="t('core.header.logoTitle')" :subtitle="t('core.header.accountDialog.title')"></logo>
</div>
Expand Down Expand Up @@ -925,6 +925,18 @@ onMounted(async () => {
margin-bottom: 20px;
}

.account-dialog {
max-height: min(90vh, 760px);
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The 760px value used for max-height is a magic number. For better maintainability and consistency, consider defining such fixed dimensions as CSS variables or design tokens, especially if this value is part of a broader design system or might be reused. This makes it easier to manage and update UI dimensions centrally.

display: flex;
flex-direction: column;
}

.account-dialog__content {
flex: 1 1 auto;
min-height: 0;
overflow-y: auto;
}

.account-dialog .v-btn {
text-transform: none;
font-weight: 500;
Expand Down
Loading