fix: register javascript mime types for dashboard assets

[1zzxy1]

Summary

• register explicit .js and .mjs MIME mappings before Quart serves dashboard static assets
• avoid Windows host MIME associations returning text/plain for module scripts and causing a blank WebUI
• add a small regression test for the MIME registration helper

Fixes #6253

Testing

• uv run --group dev pytest tests/test_dashboard_static_mime.py -q

Summary by Sourcery

Register correct JavaScript MIME types for dashboard static assets to ensure the WebUI loads correctly across platforms.

Bug Fixes:

• Force .js and .mjs dashboard assets to be served with a JavaScript MIME type to avoid incorrect text/plain responses on some platforms.

Tests:

• Add a regression test verifying that JavaScript MIME types are registered for .js and .mjs dashboard assets.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue where the dashboard WebUI would appear blank on Windows systems due to incorrect MIME type handling for JavaScript module scripts. By explicitly configuring the server to recognize '.js' and '.mjs' files as 'application/javascript', it ensures consistent and correct asset delivery across different operating systems, thereby restoring full dashboard functionality.

Highlights

• MIME Type Registration: Explicitly registered 'application/javascript' MIME types for '.js' and '.mjs' files to ensure proper serving of dashboard static assets.
• Windows Compatibility Fix: Addressed an issue where Windows hosts might incorrectly serve module scripts as 'text/plain', leading to a blank WebUI, by overriding platform-specific MIME mappings.
• Regression Test Added: Included a new regression test to verify the correct registration of JavaScript MIME types, ensuring the fix remains stable.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request introduces a new function _ensure_static_asset_mime_types to explicitly set MIME types for JavaScript files (.js and .mjs) to application/javascript, addressing potential inconsistencies across different operating systems. This function is currently called within the AstrBotDashboard's __init__ method, and a new test has been added to verify its functionality. The review suggests moving the call to _ensure_static_asset_mime_types to the module level to ensure it's executed only once upon import, preventing redundant calls if AstrBotDashboard is instantiated multiple times.

[gemini-code-assist]

For one-time initializations like this, it's best practice to execute them at the module level. This ensures the setup runs only once when the module is imported, avoiding redundant calls if AstrBotDashboard is instantiated multiple times.

Please call _ensure_static_asset_mime_types() here, and remove the call from AstrBotDashboard.__init__.

Suggested change

	_ensure_static_asset_mime_types()

[gemini-code-assist]

Since the MIME type registration is now handled at the module level, this call inside __init__ is redundant and should be removed.