Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The self ID handling across adapters is still a bit ad hoc; consider centralizing bot/self ID resolution in the common base class (or a shared helper) so that Discord/Misskey/Telegram/WeCom/Weixin don’t each manage their own
bot_self_idlifecycle differently and drift again. - In the Discord adapter,
bot_self_idis first set from the first received message insideon_received, which meanssend_by_sessioncould run whilebot_self_idis stillNone; you may want to initialize it fromself.client.user.idonce the client is ready instead of lazily on first message.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The self ID handling across adapters is still a bit ad hoc; consider centralizing bot/self ID resolution in the common base class (or a shared helper) so that Discord/Misskey/Telegram/WeCom/Weixin don’t each manage their own `bot_self_id` lifecycle differently and drift again.
- In the Discord adapter, `bot_self_id` is first set from the first received message inside `on_received`, which means `send_by_session` could run while `bot_self_id` is still `None`; you may want to initialize it from `self.client.user.id` once the client is ready instead of lazily on first message.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames client_self_id to bot_self_id across several platform adapters, including Discord and Misskey, and removes unused ID initializations in the Telegram, WeCom, and WeChat adapters. Feedback identifies a redundant null check added to the Telegram adapter and suggests improvements for the Discord adapter to ensure the bot's identity is retrieved reliably from the client user object and correctly typed as a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #7187
closes: #7188
Modifications / 改动点
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Align bot self-identifier handling across Misskey and Discord adapters and clean up unused client identifiers in other platform adapters to resolve hot-reload and self-id related issues.
Bug Fixes:
Enhancements: