Skip to content

fix: resolve Discord/Misskey hot reload issue by fixing client_self_id misuse#7331

Merged
Soulter merged 2 commits intomasterfrom
fix/7187
Apr 3, 2026
Merged

fix: resolve Discord/Misskey hot reload issue by fixing client_self_id misuse#7331
Soulter merged 2 commits intomasterfrom
fix/7187

Conversation

@Soulter
Copy link
Copy Markdown
Member

@Soulter Soulter commented Apr 3, 2026

fixes: #7187
closes: #7188

Modifications / 改动点

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果


Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Align bot self-identifier handling across Misskey and Discord adapters and clean up unused client identifiers in other platform adapters to resolve hot-reload and self-id related issues.

Bug Fixes:

  • Correct Misskey adapter self-id usage to reliably detect bot messages, mentions, and visibility for events and message conversion.
  • Initialize and propagate the Discord bot self-id from received events so outgoing and converted messages use the correct identifier.
  • Prevent errors in the Telegram adapter when applying captions on updates without a message payload.

Enhancements:

  • Rename client self-id fields to a clearer bot_self_id in Misskey and Discord adapters and update related utilities for consistency.
  • Remove unused placeholder client_self_id fields from Telegram, WeCom, and Weixin Official Account adapters.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 3, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The self ID handling across adapters is still a bit ad hoc; consider centralizing bot/self ID resolution in the common base class (or a shared helper) so that Discord/Misskey/Telegram/WeCom/Weixin don’t each manage their own bot_self_id lifecycle differently and drift again.
  • In the Discord adapter, bot_self_id is first set from the first received message inside on_received, which means send_by_session could run while bot_self_id is still None; you may want to initialize it from self.client.user.id once the client is ready instead of lazily on first message.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The self ID handling across adapters is still a bit ad hoc; consider centralizing bot/self ID resolution in the common base class (or a shared helper) so that Discord/Misskey/Telegram/WeCom/Weixin don’t each manage their own `bot_self_id` lifecycle differently and drift again.
- In the Discord adapter, `bot_self_id` is first set from the first received message inside `on_received`, which means `send_by_session` could run while `bot_self_id` is still `None`; you may want to initialize it from `self.client.user.id` once the client is ready instead of lazily on first message.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dosubot dosubot bot added the area:platform The bug / feature is about IM platform adapter, such as QQ, Lark, Telegram, WebChat and so on. label Apr 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames client_self_id to bot_self_id across several platform adapters, including Discord and Misskey, and removes unused ID initializations in the Telegram, WeCom, and WeChat adapters. Feedback identifies a redundant null check added to the Telegram adapter and suggests improvements for the Discord adapter to ensure the bot's identity is retrieved reliably from the client user object and correctly typed as a string.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 3, 2026
@Soulter Soulter merged commit 6a7b622 into master Apr 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:platform The bug / feature is about IM platform adapter, such as QQ, Lark, Telegram, WebChat and so on. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Discord平台在配置热重载后,主动发送消息有概率仍然命中旧的适配器实例

1 participant