-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix:新增vLLM Embedding提供商,解决新版vllm部署bge-m3这类无法瘦身的embedding模型时,不允许传入dimensions参数,而原有的OpenAI Embedding会强制传入向量维度参数导致对vllm embedding的请求失败的问题。 #8236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Creeper3222
wants to merge
6
commits into
AstrBotDevs:master
Choose a base branch
from
Creeper3222:fix/vllm-embedding-compatibility
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8580735
fix(provider): resolve vLLM embedding compatibility and dimension inf…
Creeper3222 f08962a
refactor: use API Key 'vllm' as indicator and add WebUI hints
Creeper3222 b62927a
refactor: move UI hints to i18n metadata and update config defaults
Creeper3222 c281462
Integrate vLLM embedding provider into core
Creeper3222 1e586e8
Normalize vLLM embedding provider defaults
Creeper3222 ac673be
fix(provider): address embedding review feedback
Creeper3222 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from typing import Any | ||
|
|
||
| from astrbot import logger | ||
|
|
||
|
|
||
| COMMON_MODEL_DIMENSIONS = { | ||
| "bge-m3": 1024, | ||
| "bge-large-en-v1.5": 1024, | ||
| "bge-large-zh-v1.5": 1024, | ||
| "text-embedding-3-small": 1536, | ||
| "text-embedding-3-large": 3072, | ||
| "text-embedding-ada-002": 1536, | ||
| } | ||
|
|
||
|
|
||
| def parse_configured_embedding_dimension( | ||
| raw_dimension: Any, | ||
| *, | ||
| provider_label: str, | ||
| provider_id: str, | ||
| ) -> int | None: | ||
| if raw_dimension in (None, ""): | ||
| return None | ||
|
|
||
| try: | ||
| dimension = int(raw_dimension) | ||
| except (TypeError, ValueError): | ||
| logger.warning( | ||
| "[%s] %s 的 embedding_dimensions 不是有效整数: %r", | ||
| provider_label, | ||
| provider_id, | ||
| raw_dimension, | ||
| ) | ||
| return None | ||
|
|
||
| return dimension if dimension > 0 else None | ||
|
|
||
|
|
||
| def infer_embedding_dimension_from_model(model_name: Any) -> int | None: | ||
| normalized_model = str(model_name or "").strip().lower() | ||
| for model_key, dimension in COMMON_MODEL_DIMENSIONS.items(): | ||
| if model_key in normalized_model: | ||
| return dimension | ||
| return None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.