feat(webui): add direct access button on plugin cards and improve embedded page height#8369
Merged
Conversation
added 2 commits
May 27, 2026 17:35
Include discovered page names for each plugin in the /api/plugin/get response, so the frontend can determine whether a plugin has a WebUI without an extra detail request.
- Add "open-webui" button on plugin cards when plugin has pages - Navigate to plugin's first page directly from the card - Adjust PluginPagePage iframe height for better UX - Add i18n labels (zh-CN/en-US/ru-RU)
dosubot
Bot
added
size:M
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
get_plugins, calling_discover_plugin_pagesfor every plugin on the list endpoint could become expensive with many plugins; consider caching results or providing a lightweight flag on the list and deferring full page discovery to a detail endpoint. - The
openPluginWebuihandler always routes topages[0]; if the order ofpagesis not guaranteed or you later support a 'default' page, consider making the target page deterministic (e.g., by sorting, picking a specific name likeindex, or using a designated default field).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `get_plugins`, calling `_discover_plugin_pages` for every plugin on the list endpoint could become expensive with many plugins; consider caching results or providing a lightweight flag on the list and deferring full page discovery to a detail endpoint.
- The `openPluginWebui` handler always routes to `pages[0]`; if the order of `pages` is not guaranteed or you later support a 'default' page, consider making the target page deterministic (e.g., by sorting, picking a specific name like `index`, or using a designated default field).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a feature to discover and open plugin-specific UI pages directly from the dashboard. It updates the backend to fetch plugin pages and adds an "Open Plugin UI" button to the frontend's ExtensionCard component, along with corresponding localization strings. Feedback highlights a potential performance bottleneck due to sequential disk I/O when discovering plugin pages in a loop, recommending concurrent processing using asyncio.gather. Additionally, a UX improvement is suggested to disable the "Open Plugin UI" button when a plugin is deactivated to prevent errors.
added 3 commits
May 27, 2026 18:03
Replace sequential await loop with concurrent processing to avoid blocking on disk I/O when discovering plugin pages.
Prevent navigation to a disabled plugin's WebUI page which would result in an error.
- test_plugin_get_excludes_scanned_pages: expect pages field now present - test_plugins: use name-based lookup instead of exact count assertion
dosubot
Bot
added
size:XS
Soulter
approved these changes
May 27, 2026
Dt8333
reviewed
May 28, 2026
| ): | ||
| continue | ||
| _plugin_resp.append(_t) | ||
| _plugin_resp.append(_t) |
5 tasks
lxfight
pushed a commit
that referenced
this pull request
May 28, 2026
Fixed the issue of duplicate plugin cards introduced in #8369
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications / 改动点
Backend: Added
pagesfield to/api/plugin/getresponse, listing discovered page names for each plugin so thefrontend can determine WebUI availability without an extra detail request.
Frontend: Added a "Open Plugin UI" button (
mdi-monitor-dashboard) on installed plugin cards, visible only whenthe plugin has pages. Clicking navigates directly to the plugin's first page.
UX: Adjusted PluginPagePage iframe minimum height for a better viewing experience.
i18n: Added
openWebuilabel for zh-CN, en-US, and ru-RU locales.This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能，已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试，并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库，或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Expose plugin WebUI availability from the backend and add a direct access entry point in the dashboard, along with minor layout and localization updates.
New Features:
Enhancements: