-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(webui): add direct access button on plugin cards and improve embedded page height #8369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cbe424d
feat(plugin): add pages field to plugin list API response
ec4028d
feat(webui): add direct WebUI access button on plugin cards
5aae033
perf(plugin): use asyncio.gather for concurrent page discovery
ff990c6
fix(webui): disable open plugin UI button when plugin is deactivated
c101e9a
test: update plugin API tests to match pages field in list response
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1262,12 +1262,23 @@ def _get_plugin_installed_at(self, plugin) -> str | None: | |
| async def get_plugins(self): | ||
| _plugin_resp = [] | ||
| plugin_name = request.args.get("name") | ||
| for plugin in self.plugin_manager.context.get_all_stars(): | ||
| if plugin_name and plugin.name != plugin_name: | ||
| continue | ||
|
|
||
| plugins = [ | ||
| p | ||
| for p in self.plugin_manager.context.get_all_stars() | ||
| if not (plugin_name and p.name != plugin_name) | ||
| ] | ||
|
|
||
| async def process_plugin(plugin): | ||
| logo_url = None | ||
| if plugin.logo_path: | ||
| logo_url = await self.get_plugin_logo_token(plugin.logo_path) | ||
| pages = await self._discover_plugin_pages(plugin) | ||
| return plugin, logo_url, pages | ||
|
|
||
| results = await asyncio.gather(*(process_plugin(p) for p in plugins)) | ||
|
|
||
| for plugin, logo_url, pages in results: | ||
| _t = { | ||
| "name": plugin.name, | ||
| "repo": "" if plugin.repo is None else plugin.repo, | ||
|
|
@@ -1283,6 +1294,7 @@ async def get_plugins(self): | |
| "astrbot_version": plugin.astrbot_version, | ||
| "installed_at": self._get_plugin_installed_at(plugin), | ||
| "i18n": plugin.i18n, | ||
| "pages": [p.name for p in pages], | ||
| } | ||
| # 检查是否为全空的幽灵插件 | ||
| if not any( | ||
|
|
@@ -1296,6 +1308,7 @@ async def get_plugins(self): | |
| ): | ||
| continue | ||
| _plugin_resp.append(_t) | ||
| _plugin_resp.append(_t) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? |
||
| return ( | ||
| Response() | ||
| .ok(_plugin_resp, message=self.plugin_manager.failed_plugin_info) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.