-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix: segmented reply not applied to send_message_to_user messages #9111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (complexity): Consider extracting the platform support checks, chain-building logic, and async send loop into shared
segmented_replyutilities so this tool remains thin and mirrors the pipeline’s behavior.You can keep the new behavior but move most of the orchestration into
segmented_replyutilities so this tool stays thin and aligned with the pipeline.1. Centralize platform support logic
Right now
_get_segmented_reply_confknows too much about platform details. Move that logic intosegmented_reply.py:Then
_get_segmented_reply_confbecomes flatter and only does config plumbing:2. Extract generic chain-building into a shared utility
_build_segmented_chainsis generic (“components → chains”) and mostly mirrors pipeline behavior. Move it intosegmented_reply.pyand keep it pure:Then the tool doesn’t need
_build_segmented_chainsat all:3. Generalize the async sending loop
The sleep/scheduling logic in
_send_segmented_chainscan also be a shared helper, since it already uses shared primitives (parse_interval_range,calc_segment_interval):And in the tool you only adapt the context type:
This keeps all current behavior (including header/body handling,
Recordspecial casing, and interval logic), but:segmented_reply.py,call()flow close to “get config → maybe segment → send”.