Skip to content

fix: update tool call prompt for clearer execution guidelines #9133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Soulter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: update tool call prompt for clearer execution guidelines #9133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion astrbot/core/astr_main_agent_resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
TOOL_CALL_PROMPT = (
"When using tools: "
"never return an empty response; "
"briefly explain the purpose before calling a tool; "
"give concise progress updates while working and a short final "
"summary with changed files, verification, and any caveats; "
"run relevant checks when practical, and clearly say when a check was not run."

@gemini-code-assist gemini-code-assist Bot Jul 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The string literal on line 30 is implicitly concatenated with the string literal on line 31. Because line 30 does not end with a semicolon or space (e.g., ; ), the two instructions will merge into: ...clearly say when a check was not run.follow the tool schema exactly.... Adding a semicolon and space at the end of line 30 ensures the instructions remain distinct and clear for the LLM.

Suggested change
"run relevant checks when practical, and clearly say when a check was not run."
"run relevant checks when practical, and clearly say when a check was not run; "

"follow the tool schema exactly and do not invent parameters; "
"after execution, briefly summarize the result for the user; "
"keep the conversation style consistent."
Expand Down
Loading