simplify validator dummy config and lazy data dir

Author: zouyonghe

scripts/validate_plugins/run.py

@@ -654,27 +654,14 @@ def __bool__(self) -> bool:
 
 class DummyConfig(dict):
     def __init__(self, initial=None) -> None:
-        super().__init__()
-        if initial:
-            for key, value in initial.items():
-                self[key] = value
-
-    @staticmethod
-    def _wrap(value):
-        if isinstance(value, dict) and not isinstance(value, DummyConfig):
-            return DummyConfig(value)
-        return value
-
-    def __setitem__(self, key, value) -> None:
-        super().__setitem__(key, self._wrap(value))
-
-    def __getitem__(self, key):
-        if key in self:
-            return super().__getitem__(key)
+        super().__init__(initial or {})
+
+    def __missing__(self, key):
+        del key
         return NullStub()
 
     def __getattr__(self, name: str):
-        return self.get(name)
+        return self[name]
 
 
 class DummyContext:
@@ -683,25 +670,30 @@ def __init__(self) -> None:
         self._astrbot_root = Path(os.environ.get("ASTRBOT_ROOT", Path.cwd())).resolve()
         self._data_root = self._astrbot_root / "data"
         self._plugin_data_dir = self._data_root / "plugin_data"
-        self._plugin_data_dir.mkdir(parents=True, exist_ok=True)
         self._config = DummyConfig(
             {
                 "wake_prefix": [],
-                "dashboard": {},
+                "dashboard": DummyConfig(),
                 "admins_id": [],
                 "admin_ids": [],
-                "platform_settings": {
+                "platform_settings": DummyConfig(
+                    {
                     "aiocqhttp": {},
                     "qqofficial": {},
                     "telegram": {},
                     "gewechat": {},
                     "wechatpadpro": {},
-                },
+                    }
+                ),
                 "data_dir": str(self._data_root),
             }
         )
         self.config = self._config
 
+    def _ensure_plugin_data_dir(self) -> Path:
+        self._plugin_data_dir.mkdir(parents=True, exist_ok=True)
+        return self._plugin_data_dir
+
     def get_all_stars(self):
         try:
             from astrbot.core.star.star import star_registry
@@ -735,11 +727,10 @@ def get_config(self, umo: str | None = None):
         return self._config
 
     def get_context_config(self):
-        return self._config
+        return self.get_config()
 
     def get_data_dir(self) -> str:
-        self._plugin_data_dir.mkdir(parents=True, exist_ok=True)
-        return str(self._plugin_data_dir)
+        return str(self._ensure_plugin_data_dir())
 
     def __getattr__(self, name: str) -> NullStub:
         del name

tests/test_validate_plugins.py

@@ -386,6 +386,23 @@ def test_load_plugins_index_rejects_non_dict_values(self):
 
 
 class DummyContextStubTests(unittest.IsolatedAsyncioTestCase):
+    def test_dummy_context_defers_plugin_data_dir_creation_until_requested(self):
+        module = load_validator_module()
+
+        with tempfile.TemporaryDirectory() as tmp_dir:
+            astrbot_root = Path(tmp_dir) / "astrbot-root"
+            plugin_data_dir = astrbot_root / "data" / "plugin_data"
+
+            with mock.patch.dict(os.environ, {"ASTRBOT_ROOT": str(astrbot_root)}, clear=True):
+                context = module.DummyContext()
+                dir_exists_before = plugin_data_dir.exists()
+                created_dir = Path(context.get_data_dir())
+                dir_exists_after = plugin_data_dir.is_dir()
+
+        self.assertFalse(dir_exists_before)
+        self.assertEqual(created_dir.resolve(), plugin_data_dir.resolve())
+        self.assertTrue(dir_exists_after)
+
     def test_dummy_context_returns_worker_data_dir_for_plugin_storage(self):
         module = load_validator_module()