downgrade missing metadata fields to warnings

Author: zouyonghe

scripts/validate_plugins/run.py

@@ -46,6 +46,7 @@ def build_result(
     ok: bool,
     stage: str,
     message: str,
+    severity: str | None = None,
     plugin_dir_name: str | None = None,
     details: dict | str | None = None,
 ) -> dict:
@@ -56,6 +57,7 @@ def build_result(
         "ok": ok,
         "stage": stage,
         "message": message,
+        "severity": severity or ("pass" if ok else "fail"),
     }
     if plugin_dir_name:
         result["plugin_dir_name"] = plugin_dir_name
@@ -212,6 +214,7 @@ def precheck_plugin_directory(plugin_dir: Path) -> dict:
     if missing:
         return {
             "ok": False,
+            "severity": "warn",
             "stage": "metadata",
             "message": f"missing required metadata fields: {', '.join(missing)}",
         }
@@ -262,12 +265,14 @@ def build_worker_sys_path(*, astrbot_root: Path, astrbot_path: Path) -> list[str
 
 
 def build_report(results: list[dict]) -> dict:
-    passed = sum(1 for result in results if result.get("ok"))
-    failed = len(results) - passed
+    passed = sum(1 for result in results if result.get("severity") == "pass")
+    warned = sum(1 for result in results if result.get("severity") == "warn")
+    failed = sum(1 for result in results if result.get("severity") == "fail")
     return {
         "summary": {
             "total": len(results),
             "passed": passed,
+            "warned": warned,
             "failed": failed,
         },
         "results": results,
@@ -442,6 +447,7 @@ def validate_plugin(
             ok=False,
             stage=precheck["stage"],
             message=precheck["message"],
+            severity=precheck.get("severity"),
             details=precheck.get("details"),
         )
 
@@ -535,7 +541,8 @@ def task(index: int, plugin: str, plugin_data: dict) -> tuple[int, dict]:
                 )
 
             results[original_index - 1] = result
-            status = "PASS" if result.get("ok") else "FAIL"
+            severity = result.get("severity", "pass" if result.get("ok") else "fail")
+            status = {"pass": "PASS", "warn": "WARN", "fail": "FAIL"}.get(severity, "FAIL")
             stage = result.get("stage", "unknown")
             message = result.get("message", "")
             print(f"[{original_index}/{total}] {status} {plugin} [{stage}] {message}", flush=True)

tests/test_validate_plugins.py

@@ -400,8 +400,8 @@ def test_validate_selected_plugins_emits_progress_and_result_lines(self):
             ("plugin-b", {"repo": "https://github.com/example/plugin-b"}),
         ]
         fake_results = [
-            {"plugin": "plugin-a", "ok": True, "stage": "load", "message": "ok"},
-            {"plugin": "plugin-b", "ok": False, "stage": "metadata", "message": "invalid metadata.yaml"},
+            {"plugin": "plugin-a", "ok": True, "severity": "pass", "stage": "load", "message": "ok"},
+            {"plugin": "plugin-b", "ok": False, "severity": "warn", "stage": "metadata", "message": "missing required metadata fields: desc"},
         ]
 
         with mock.patch.object(module, "validate_plugin", side_effect=fake_results) as validate_mock:
@@ -420,7 +420,7 @@ def test_validate_selected_plugins_emits_progress_and_result_lines(self):
         self.assertEqual(validate_mock.call_count, 2)
         print_mock.assert_any_call("[1/2] Queued plugin-a", flush=True)
         print_mock.assert_any_call("[1/2] PASS plugin-a [load] ok", flush=True)
-        print_mock.assert_any_call("[2/2] FAIL plugin-b [metadata] invalid metadata.yaml", flush=True)
+        print_mock.assert_any_call("[2/2] WARN plugin-b [metadata] missing required metadata fields: desc", flush=True)
 
     def test_validate_selected_plugins_preserves_result_order_with_out_of_order_completion(self):
         module = load_validator_module()
@@ -592,6 +592,7 @@ def test_reports_missing_required_metadata_fields(self):
             result = module.precheck_plugin_directory(plugin_dir)
 
         self.assertFalse(result["ok"])
+        self.assertEqual(result["severity"], "warn")
         self.assertEqual(result["stage"], "metadata")
         self.assertIn("desc", result["message"])
         self.assertIn("version", result["message"])
@@ -652,19 +653,21 @@ def test_worker_sys_path_includes_astrbot_root_before_codebase(self):
 
 
 class ReportBuilderTests(unittest.TestCase):
-    def test_build_report_counts_passed_and_failed_results(self):
+    def test_build_report_counts_passed_warned_and_failed_results(self):
         module = load_validator_module()
 
         report = module.build_report(
             [
-                {"plugin": "plugin-a", "ok": True, "stage": "load", "message": "ok"},
-                {"plugin": "plugin-b", "ok": False, "stage": "metadata", "message": "missing desc"},
+                {"plugin": "plugin-a", "ok": True, "severity": "pass", "stage": "load", "message": "ok"},
+                {"plugin": "plugin-b", "ok": False, "severity": "warn", "stage": "metadata", "message": "missing desc"},
+                {"plugin": "plugin-c", "ok": False, "severity": "fail", "stage": "load", "message": "boom"},
             ]
         )
 
-        self.assertEqual(report["summary"]["total"], 2)
+        self.assertEqual(report["summary"]["total"], 3)
         self.assertEqual(report["summary"]["passed"], 1)
         self.assertEqual(report["summary"]["failed"], 1)
+        self.assertEqual(report["summary"]["warned"], 1)
         self.assertEqual(report["results"][1]["plugin"], "plugin-b")