Skip to content

fix(lsp): simplify sqls.nvim setup for Neovim >=0.11#1769

Open
theseriff wants to merge 2 commits into
AstroNvim:mainfrom
theseriff:fix/sqls
Open

fix(lsp): simplify sqls.nvim setup for Neovim >=0.11#1769
theseriff wants to merge 2 commits into
AstroNvim:mainfrom
theseriff:fix/sqls

Conversation

@theseriff

Copy link
Copy Markdown

📑 Description

The sqls.nvim plugin has been updated and now requires Neovim >=0.11. The previous manual on_attach via an LspAttach autocmd is no longer needed and causes issues (e.g., errors or LSP not attaching correctly).

Changes made:

  • Removed the custom autocmds block that manually called sqls.on_attach
  • Removed the dependency declaration with astrocore for that autocmd
  • Simplified the plugin entry to just { "nanotee/sqls.nvim" }

📖 Additional Information

  • Breaking changes: None – the SQL LSP functionality remains the same.
  • New requirement: Neovim 0.11 or higher is now needed (required by the plugin itself).
  • Verification: After this change, sqls should attach automatically when opening SQL files, without any extra callbacks.

@github-actions

Copy link
Copy Markdown

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@theseriff theseriff changed the title fix(sqls): remove deprecated api fix(lsp): simplify sqls.nvim setup for Neovim >=0.11 Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant