Fix JDK 11 build compatibility for dependency bumps

Revert JDK-incompatible major version bumps that break the JDK 11
compile-and-check CI job:
- error_prone_core: keep 2.31.0 default, use 2.48.0 in JDK 21+ profile
- nullaway: keep 0.12.6 default, use 0.13.1 in JDK 21+ profile
- junit-bom: revert 6.0.3 to 5.13.0 (JUnit 6 requires JDK 17+)
- tomcat-embed-core: revert 11.0.18 to 10.1.50 (Tomcat 11 requires JDK 17+)

Restructure Maven profiles so errorprone-jdk21 activates on [21,) for
newer Error Prone/NullAway and errorprone-jdk25 only adds the
--should-stop=ifError=FLOW flag.

Configure dependabot to ignore major version bumps on these four
dependencies to prevent future incompatible upgrades.

Author: hyperxpro

.github/dependabot.yml

@@ -8,6 +8,15 @@ updates:
       dependencies:
         patterns:
           - "*"
+    ignore:
+      - dependency-name: "com.google.errorprone:error_prone_core"
+        update-types: ["version-update:semver-major"]
+      - dependency-name: "com.uber.nullaway:nullaway"
+        update-types: ["version-update:semver-major"]
+      - dependency-name: "org.junit:junit-bom"
+        update-types: ["version-update:semver-major"]
+      - dependency-name: "org.apache.tomcat.embed:tomcat-embed-core"
+        update-types: ["version-update:semver-major"]
 
   - package-ecosystem: "github-actions"
     directory: "/"

client/pom.xml

@@ -31,7 +31,7 @@
         <javaModuleName>org.asynchttpclient.client</javaModuleName>
 
         <jetty.version>11.0.26</jetty.version>
-        <tomcat.version>11.0.18</tomcat.version>
+        <tomcat.version>10.1.50</tomcat.version>
         <commons-io.version>2.21.0</commons-io.version>
         <mockito.version>5.23.0</mockito.version>
         <hamcrest.version>3.0</hamcrest.version>

pom.xml

@@ -102,7 +102,7 @@
             <dependency>
                 <groupId>org.junit</groupId>
                 <artifactId>junit-bom</artifactId>
-                <version>6.0.3</version>
+                <version>5.13.0</version>
                 <type>pom</type>
                 <scope>import</scope>
             </dependency>
@@ -325,12 +325,12 @@
                         <path>
                             <groupId>com.google.errorprone</groupId>
                             <artifactId>error_prone_core</artifactId>
-                            <version>2.48.0</version>
+                            <version>2.31.0</version>
                         </path>
                         <path>
                             <groupId>com.uber.nullaway</groupId>
                             <artifactId>nullaway</artifactId>
-                            <version>0.13.1</version>
+                            <version>0.12.6</version>
                         </path>
                         <!-- Other annotation processors go here -->
                     </annotationProcessorPaths>
@@ -483,19 +483,16 @@
 
     <profiles>
         <profile>
-            <id>errorprone-jdk25</id>
+            <id>errorprone-jdk21</id>
             <activation>
-                <jdk>[25,)</jdk>
+                <jdk>[21,)</jdk>
             </activation>
             <build>
                 <plugins>
                     <plugin>
                         <groupId>org.apache.maven.plugins</groupId>
                         <artifactId>maven-compiler-plugin</artifactId>
                         <configuration>
-                            <compilerArgs combine.children="append">
-                                <arg>--should-stop=ifError=FLOW</arg>
-                            </compilerArgs>
                             <annotationProcessorPaths combine.self="override">
                                 <path>
                                     <groupId>com.google.errorprone</groupId>
@@ -513,5 +510,24 @@
                 </plugins>
             </build>
         </profile>
+        <profile>
+            <id>errorprone-jdk25</id>
+            <activation>
+                <jdk>[25,)</jdk>
+            </activation>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-compiler-plugin</artifactId>
+                        <configuration>
+                            <compilerArgs combine.children="append">
+                                <arg>--should-stop=ifError=FLOW</arg>
+                            </compilerArgs>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
     </profiles>
 </project>