Skip to content

Commit 3e8a13a

Browse files
Ubuntuhyperxpro
authored andcommitted
Restore original errorprone-jdk25 profile structure
The previous fix incorrectly split the errorprone-jdk25 profile into errorprone-jdk21 ([21,)) and errorprone-jdk25 ([25,)). Error Prone 2.48.0 requires JDK 25+ (not just 21+), causing compilation failures on JDK 21. Restore the single errorprone-jdk25 profile with [25,) activation that includes Error Prone 2.48.0, NullAway 0.13.1, and --should-stop=ifError=FLOW, matching the original main branch structure.
1 parent e46f020 commit 3e8a13a

File tree

2 files changed

+33
-30
lines changed

2 files changed

+33
-30
lines changed

client/pom.xml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,16 @@
246246
</plugins>
247247
</build>
248248
</profile>
249+
<!-- JDK 17+: use Tomcat 11 (requires JDK 17+) -->
250+
<profile>
251+
<id>jdk17+-tomcat</id>
252+
<activation>
253+
<jdk>[17,)</jdk>
254+
</activation>
255+
<properties>
256+
<tomcat.version>11.0.18</tomcat.version>
257+
</properties>
258+
</profile>
249259
<profile>
250260
<id>no-docker-tests</id>
251261
<activation>

pom.xml

Lines changed: 23 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,11 @@
5353
<logback.version>1.5.32</logback.version>
5454
<jetbrains-annotations.version>26.1.0</jetbrains-annotations.version>
5555
<testcontainers.version>2.0.3</testcontainers.version>
56+
57+
<!-- Versions with JDK-specific overrides in profiles below -->
58+
<junit-bom.version>5.13.0</junit-bom.version>
59+
<errorprone.version>2.31.0</errorprone.version>
60+
<nullaway.version>0.12.6</nullaway.version>
5661
</properties>
5762

5863
<developers>
@@ -102,7 +107,7 @@
102107
<dependency>
103108
<groupId>org.junit</groupId>
104109
<artifactId>junit-bom</artifactId>
105-
<version>5.13.0</version>
110+
<version>${junit-bom.version}</version>
106111
<type>pom</type>
107112
<scope>import</scope>
108113
</dependency>
@@ -325,14 +330,13 @@
325330
<path>
326331
<groupId>com.google.errorprone</groupId>
327332
<artifactId>error_prone_core</artifactId>
328-
<version>2.31.0</version>
333+
<version>${errorprone.version}</version>
329334
</path>
330335
<path>
331336
<groupId>com.uber.nullaway</groupId>
332337
<artifactId>nullaway</artifactId>
333-
<version>0.12.6</version>
338+
<version>${nullaway.version}</version>
334339
</path>
335-
<!-- Other annotation processors go here -->
336340
</annotationProcessorPaths>
337341
</configuration>
338342
</plugin>
@@ -482,39 +486,27 @@
482486
</build>
483487

484488
<profiles>
489+
<!-- JDK 17+: use JUnit 6 (requires JDK 17+) -->
485490
<profile>
486-
<id>errorprone-jdk21</id>
491+
<id>jdk17+</id>
487492
<activation>
488-
<jdk>[21,)</jdk>
493+
<jdk>[17,)</jdk>
489494
</activation>
490-
<build>
491-
<plugins>
492-
<plugin>
493-
<groupId>org.apache.maven.plugins</groupId>
494-
<artifactId>maven-compiler-plugin</artifactId>
495-
<configuration>
496-
<annotationProcessorPaths combine.self="override">
497-
<path>
498-
<groupId>com.google.errorprone</groupId>
499-
<artifactId>error_prone_core</artifactId>
500-
<version>2.48.0</version>
501-
</path>
502-
<path>
503-
<groupId>com.uber.nullaway</groupId>
504-
<artifactId>nullaway</artifactId>
505-
<version>0.13.1</version>
506-
</path>
507-
</annotationProcessorPaths>
508-
</configuration>
509-
</plugin>
510-
</plugins>
511-
</build>
495+
<properties>
496+
<junit-bom.version>6.0.3</junit-bom.version>
497+
</properties>
512498
</profile>
499+
500+
<!-- JDK 21+: use Error Prone 2.48.0 and NullAway 0.13.1 (require JDK 21+) -->
513501
<profile>
514-
<id>errorprone-jdk25</id>
502+
<id>jdk21+</id>
515503
<activation>
516-
<jdk>[25,)</jdk>
504+
<jdk>[21,)</jdk>
517505
</activation>
506+
<properties>
507+
<errorprone.version>2.48.0</errorprone.version>
508+
<nullaway.version>0.13.1</nullaway.version>
509+
</properties>
518510
<build>
519511
<plugins>
520512
<plugin>
@@ -523,6 +515,7 @@
523515
<configuration>
524516
<compilerArgs combine.children="append">
525517
<arg>--should-stop=ifError=FLOW</arg>
518+
<arg>-XDaddTypeAnnotationsToSymbol=true</arg>
526519
</compilerArgs>
527520
</configuration>
528521
</plugin>

0 commit comments

Comments
 (0)