Skip to content

Commit 9f44682

Browse files
Copilotdoom369
andauthored
Extract real domain URLs as constants in test class
Agent-Logs-Url: https://github.com/doom369/async-http-client/sessions/ef98f786-3665-4a5f-9005-60ebdba761b1 Co-authored-by: doom369 <1536494+doom369@users.noreply.github.com>
1 parent 0973e8c commit 9f44682

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

client/src/test/java/org/asynchttpclient/AddressResolverGroupTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@
4545

4646
public class AddressResolverGroupTest extends HttpTest {
4747

48+
private static final String GOOGLE_URL = "https://www.google.com/";
49+
private static final String EXAMPLE_URL = "https://www.example.com/";
50+
4851
private HttpServer server;
4952

5053
private static boolean isExternalNetworkAvailable() {
@@ -149,7 +152,7 @@ public void resolveRealDomainWithDnsResolverGroup() throws Throwable {
149152
DnsServerAddressStreamProviders.platformDefault());
150153

151154
try (AsyncHttpClient client = asyncHttpClient(config().setAddressResolverGroup(resolverGroup))) {
152-
Response response = client.prepareGet("https://www.google.com/").execute().get(20, TimeUnit.SECONDS);
155+
Response response = client.prepareGet(GOOGLE_URL).execute().get(20, TimeUnit.SECONDS);
153156
assertNotNull(response);
154157
assertTrue(response.getStatusCode() >= 200 && response.getStatusCode() < 400,
155158
"Expected successful HTTP status but got " + response.getStatusCode());
@@ -165,12 +168,12 @@ public void resolveMultipleRealDomainsWithDnsResolverGroup() throws Throwable {
165168
DnsServerAddressStreamProviders.platformDefault());
166169

167170
try (AsyncHttpClient client = asyncHttpClient(config().setAddressResolverGroup(resolverGroup))) {
168-
Response response1 = client.prepareGet("https://www.google.com/").execute().get(20, TimeUnit.SECONDS);
171+
Response response1 = client.prepareGet(GOOGLE_URL).execute().get(20, TimeUnit.SECONDS);
169172
assertNotNull(response1);
170173
assertTrue(response1.getStatusCode() >= 200 && response1.getStatusCode() < 400,
171174
"Expected successful HTTP status for google.com but got " + response1.getStatusCode());
172175

173-
Response response2 = client.prepareGet("https://www.example.com/").execute().get(20, TimeUnit.SECONDS);
176+
Response response2 = client.prepareGet(EXAMPLE_URL).execute().get(20, TimeUnit.SECONDS);
174177
assertNotNull(response2);
175178
assertTrue(response2.getStatusCode() >= 200 && response2.getStatusCode() < 400,
176179
"Expected successful HTTP status for example.com but got " + response2.getStatusCode());

0 commit comments

Comments
 (0)