Merge pull request #273 from AthennaIO/develop

feat(ignite): dont exit by default on uncaught errors

Author: jlenon7

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@athenna/core",
-  "version": "5.37.0",
+  "version": "5.38.0",
   "description": "One foundation for multiple applications.",
   "license": "MIT",
   "author": "João Lenon <lenon@athenna.io>",

package.json

@@ -88,6 +88,7 @@ export class Ignite extends Macroable {
         shutdownLogs: true,
         environments: [],
         exitOnError: true,
+        exitOnUncaughtError: false,
         loadConfigSafe: true,
         athennaRcPath: './.athennarc.json',
         uncaughtExceptionHandler: this.handleUncaughtError
@@ -529,24 +530,28 @@ export class Ignite extends Macroable {
     if (process.versions.bun || (!Is.Error(error) && !Is.Exception(error))) {
       console.error(error)
 
-      return this.safeExit(1)
+      return this.safeExitOnError(1)
     }
 
     if (!Is.Exception(error)) {
       error = error.toAthennaException()
     }
+    
+    if (!error.details) {
+      error.details = []
+    }
 
     error.details.push({ isUncaughtError: false })
 
     if (Config.is('app.logger.prettifyException', true)) {
       await Log.channelOrVanilla('exception').fatal(await error.prettify())
 
-      return this.safeExit(1)
+      return this.safeExitOnError(1)
     }
 
     await Log.channelOrVanilla('exception').fatal(error)
 
-    return this.safeExit(1)
+    return this.safeExitOnError(1)
   }
 
   /**
@@ -556,37 +561,52 @@ export class Ignite extends Macroable {
     if (process.versions.bun || (!Is.Error(error) && !Is.Exception(error))) {
       console.error(error)
 
-      return this.safeExit(1)
+      return this.safeExitOnUncaughtError(1)
     }
 
     if (!Is.Exception(error)) {
       error = error.toAthennaException()
     }
 
+    if (!error.details) {
+      error.details = []
+    }
+
     error.details.push({ isUncaughtError: true })
 
     if (Config.is('app.logger.prettifyException', true)) {
       await Log.channelOrVanilla('exception').fatal(await error.prettify())
 
-      return this.safeExit(1)
+      return this.safeExitOnUncaughtError(1)
     }
 
     await Log.channelOrVanilla('exception').fatal(error)
 
-    return this.safeExit(1)
+    return this.safeExitOnUncaughtError(1)
   }
 
   /**
    * Exit the application only if the exitOnError option is true.
    */
-  private safeExit(code: number): void {
+  private safeExitOnError(code: number): void {
     if (!this.options.exitOnError) {
       return
     }
 
     process.exit(code)
   }
 
+  /**
+   * Exit the application only if the exitOnUncaughtError option is true.
+   */
+  private safeExitOnUncaughtError(code: number): void {
+    if (!this.options.exitOnUncaughtError) {
+      return
+    }
+
+    process.exit(code)
+  }
+
   /**
    * Parse some version string to the SemverNode type.
    */

src/ignite/Ignite.ts

@@ -15,6 +15,13 @@ export type IgniteOptions = {
    */
   exitOnError?: boolean
 
+  /**
+   * Exit the application if an uncaught error occurs.
+   *
+   * @default false
+   */
+  exitOnUncaughtError?: boolean
+
   /**
    * Show boot logs of the application. If this option is true, Athenna
    * will log operations that are being executed to boot your application.