test: fix Windows test failures and lint warnings in the added suites

- Shortcuts: clear the destination in BeforeEach so the 'destination absent'
  cases are not polluted by the shortcut a previous test left in $TestDrive.
- Stop-AtlasProcess: return a real Process from the Get-Process mock so it binds
  to Stop-Process -InputObject (a pscustomobject fails binding and records 0).
- Drop the unused param() blocks from InModuleScope/-Parameters and action mocks
  that PSScriptAnalyzer flagged as unused parameters.

Author: jacksyrm

tests/Atlas.Registry.Tests.ps1

@@ -426,7 +426,6 @@ Describe 'Copy-AtlasRegistryKeyValues' {
 
     It 'returns silently when the source key is missing' {
         InModuleScope Atlas.Registry -Parameters @{ Src = $script:srcSubPath; Dst = $script:dstSubPath } {
-            param($Src, $Dst)
             { Copy-AtlasRegistryKeyValues -SourceSubPath $Src -DestinationSubPath $Dst } | Should -Not -Throw
         }
 

tests/Atlas.Shortcuts.Tests.ps1

@@ -34,6 +34,7 @@ Describe 'New-AtlasShortcut' {
         $script:linkDir = Join-Path -Path $TestDrive -ChildPath 'links'
         New-Item -Path $script:linkDir -ItemType Directory -Force | Out-Null
         $script:destination = Join-Path -Path $script:linkDir -ChildPath 'MyTool.lnk'
+        Remove-Item -LiteralPath $script:destination -Force -ErrorAction SilentlyContinue
     }
 
     It 'creates a .lnk at the destination pointing at the source, defaulting the working dir to the source folder' {

tests/Atlas.Software.Tests.ps1

@@ -104,7 +104,6 @@ Describe 'Assert-AtlasFileHash' {
         $hash = (Get-FileHash -LiteralPath $file -Algorithm SHA256).Hash
 
         InModuleScope Atlas.Software -Parameters @{ Path = $file; Hash = $hash } {
-            param($Path, $Hash)
             { Assert-AtlasFileHash -Path $Path -ExpectedSha256 $Hash -Description 'test file' } | Should -Not -Throw
         }
     }
@@ -114,7 +113,6 @@ Describe 'Assert-AtlasFileHash' {
         Set-Content -LiteralPath $file -Value 'atlas test payload' -NoNewline
 
         InModuleScope Atlas.Software -Parameters @{ Path = $file } {
-            param($Path)
             $wrongHash = 'deadbeef' * 8
             { Assert-AtlasFileHash -Path $Path -ExpectedSha256 $wrongHash -Description 'test file' } |
                 Should -Throw -ExpectedMessage '*Refusing*'
@@ -271,7 +269,6 @@ Describe 'Remove-AtlasOneDriveUserFolder' {
         $folder = Join-Path -Path $TestDrive -ChildPath 'OneDrive-missing'
 
         InModuleScope Atlas.Software -Parameters @{ Path = $folder } {
-            param($Path)
             { Remove-AtlasOneDriveUserFolder -Path $Path } | Should -Not -Throw
         }
 

tests/Atlas.TasksProcs.Tests.ps1

@@ -69,14 +69,14 @@ Describe 'Stop-AtlasProcess' {
 
     It 'force-stops a matching process' {
         Mock Get-Process -ModuleName Atlas.TasksProcs -ParameterFilter { $Name -eq 'msteams*' } -MockWith {
-            [pscustomobject]@{ ProcessName = 'msteams'; Id = 4242 }
+            [System.Diagnostics.Process]::GetCurrentProcess()
         }
         Mock Stop-Process -ModuleName Atlas.TasksProcs
 
         Stop-AtlasProcess -Name 'msteams*'
 
         Should -Invoke Stop-Process -ModuleName Atlas.TasksProcs -Times 1 -Exactly -ParameterFilter {
-            $InputObject.Id -eq 4242 -and $Force
+            $InputObject.Id -eq $PID -and $Force
         }
     }
 

tests/Atlas.Toggles.Tests.ps1

@@ -484,7 +484,7 @@ Describe 'Invoke-AtlasToggleAction success contract' {
             $succeeded = $true
             $toggleContext = [pscustomobject]@{ Name = 'T' }
 
-            Invoke-AtlasToggleAction -Action { param($Toggle) throw 'deliberate failure' } `
+            Invoke-AtlasToggleAction -Action { throw 'deliberate failure' } `
                 -ToggleContext $toggleContext -Succeeded ([ref]$succeeded)
 
             $succeeded | Should -BeFalse
@@ -501,7 +501,7 @@ Describe 'Invoke-AtlasToggleAction success contract' {
             $succeeded = $false
             $toggleContext = [pscustomobject]@{ Name = 'T' }
 
-            Invoke-AtlasToggleAction -Action { param($Toggle) Write-Error 'non-terminating' -ErrorAction Continue } `
+            Invoke-AtlasToggleAction -Action { Write-Error 'non-terminating' -ErrorAction Continue } `
                 -ToggleContext $toggleContext -Succeeded ([ref]$succeeded) 2>$null
 
             $succeeded | Should -BeTrue
@@ -517,7 +517,7 @@ Describe 'Invoke-AtlasToggleAction success contract' {
             $succeeded = $false
             $toggleContext = [pscustomobject]@{ Name = 'T' }
 
-            Invoke-AtlasToggleAction -Action { param($Toggle) } `
+            Invoke-AtlasToggleAction -Action { } `
                 -ToggleContext $toggleContext -Succeeded ([ref]$succeeded)
 
             $succeeded | Should -BeTrue
@@ -533,7 +533,7 @@ Describe 'Invoke-AtlasToggleAction success contract' {
             $succeeded = $false
             $toggleContext = [pscustomobject]@{ Name = 'T' }
 
-            $observedPreference = Invoke-AtlasToggleAction -Action { param($Toggle) [string]$ErrorActionPreference } `
+            $observedPreference = Invoke-AtlasToggleAction -Action { [string]$ErrorActionPreference } `
                 -ToggleContext $toggleContext -Succeeded ([ref]$succeeded)
 
             $observedPreference | Should -Be 'Continue'