refactor(core): move root-scoped process/task cleanup into Atlas.TasksProcs

Stop-ProcessesUnderRoots and Stop-TasksUnderRoots lived in the general-purpose
Atlas.Core alongside identically-named files in Atlas.TasksProcs, split by an
unobvious rule, with a single consumer. Move them into Atlas.TasksProcs (renamed
to the module's Stop-AtlasProcessUnderRoot / Stop-AtlasScheduledTaskUnderRoot
convention, bodies verbatim), delete the Core copies, and point the sole consumer
(Stop-AtlasFolderProcess.ps1) at the new home so each domain has one owner.

Author: jacksyrm

playbook/Executables/AtlasModules/Scripts/Internal/Stop-AtlasFolderProcess.ps1

@@ -10,6 +10,13 @@ if (-not (Test-Path -LiteralPath $coreModule -PathType Leaf)) {
 
 Import-Module $coreModule -Force
 
+$tasksProcsModule = Join-Path -Path $executablesRoot -ChildPath 'AtlasModules\Scripts\Modules\Atlas.TasksProcs\Atlas.TasksProcs.psd1'
+if (-not (Test-Path -LiteralPath $tasksProcsModule -PathType Leaf)) {
+    throw "Atlas tasks/processes module '$tasksProcsModule' is missing."
+}
+
+Import-Module $tasksProcsModule -Force
+
 $windir = [Environment]::GetFolderPath('Windows')
 $targetRoots = @(
     Join-Path -Path $windir -ChildPath 'AtlasModules'
@@ -28,8 +35,8 @@ if (-not $targetRoots) {
 }
 
 $rootsLower = $targetRoots | ForEach-Object { ($_ + '\').ToLowerInvariant() }
-Stop-ProcessesUnderRoots -RootsLower $rootsLower
-Stop-TasksUnderRoots -RootsLower $rootsLower
+Stop-AtlasProcessUnderRoot -RootsLower $rootsLower
+Stop-AtlasScheduledTaskUnderRoot -RootsLower $rootsLower
 
 $timerExePath = Join-Path -Path $windir -ChildPath 'AtlasModules\Tools\SetTimerResolution.exe'
 if (Test-Path -LiteralPath $timerExePath -PathType Leaf) {
@@ -38,7 +45,7 @@ if (Test-Path -LiteralPath $timerExePath -PathType Leaf) {
         $stream.Dispose()
     }
     catch {
-        Stop-ProcessesUnderRoots -RootsLower $rootsLower
+        Stop-AtlasProcessUnderRoot -RootsLower $rootsLower
         Start-Sleep -Milliseconds 500
     }
 }

playbook/Executables/AtlasModules/Scripts/Modules/Atlas.Core/Atlas.Core.psd1

@@ -26,9 +26,6 @@
         'Write-Title'
         'Read-Pause'
         'Read-MessageBox'
-        # Process/task helpers (absorbed from the former Utils module)
-        'Stop-ProcessesUnderRoots'
-        'Stop-TasksUnderRoots'
     )
     CmdletsToExport   = @()
     VariablesToExport = @()

playbook/Executables/AtlasModules/Scripts/Modules/Atlas.Core/Atlas.Core.psm1

@@ -6,8 +6,6 @@ foreach ($domainModule in @(
     'Logging.ps1'
     'Privilege.ps1'
     'Ui.ps1'
-    'Processes.ps1'
-    'ScheduledTasks.ps1'
     'RunAsUser.ps1'
 )) {
     $domainPath = Join-Path -Path $domainRoot -ChildPath $domainModule
@@ -22,6 +20,5 @@ Export-ModuleMember -Function @(
     'Get-AtlasContext', 'Test-AtlasOption', 'New-AtlasFlag', 'Test-AtlasFlag',
     'Write-AtlasLog', 'Start-AtlasPhase', 'Stop-AtlasPhase',
     'Test-AtlasAdmin', 'Test-AtlasTrustedInstaller', 'Assert-AtlasPrivilege', 'Invoke-AtlasTrustedInstaller', 'Invoke-AtlasAsUser', 'Get-AtlasUserProcessCommandLine',
-    'Write-Title', 'Read-Pause', 'Read-MessageBox',
-    'Stop-ProcessesUnderRoots', 'Stop-TasksUnderRoots'
+    'Write-Title', 'Read-Pause', 'Read-MessageBox'
 )

playbook/Executables/AtlasModules/Scripts/Modules/Atlas.Core/Domain/Processes.ps1

@@ -10,6 +10,8 @@
         'Enable-AtlasScheduledTask'
         'Remove-AtlasScheduledTask'
         'Stop-AtlasProcess'
+        'Stop-AtlasProcessUnderRoot'
+        'Stop-AtlasScheduledTaskUnderRoot'
     )
     CmdletsToExport   = @()
     VariablesToExport = @()

playbook/Executables/AtlasModules/Scripts/Modules/Atlas.Core/Domain/ScheduledTasks.ps1

@@ -23,5 +23,5 @@ foreach ($domainModule in @(
 
 Export-ModuleMember -Function @(
     'Disable-AtlasScheduledTask', 'Enable-AtlasScheduledTask', 'Remove-AtlasScheduledTask',
-    'Stop-AtlasProcess'
+    'Stop-AtlasProcess', 'Stop-AtlasProcessUnderRoot', 'Stop-AtlasScheduledTaskUnderRoot'
 )

playbook/Executables/AtlasModules/Scripts/Modules/Atlas.TasksProcs/Atlas.TasksProcs.psd1

@@ -24,3 +24,32 @@ function Stop-AtlasProcess {
         }
     }
 }
+
+function Stop-AtlasProcessUnderRoot {
+    param([string[]]$RootsLower)
+
+    foreach ($proc in Get-Process -ErrorAction SilentlyContinue) {
+        if (-not $proc.Path) { continue }
+
+        $procPath = try {
+            ([System.IO.Path]::GetFullPath($proc.Path)).ToLowerInvariant()
+        }
+        catch {
+            continue
+        }
+
+        foreach ($root in $RootsLower) {
+            if ($procPath.StartsWith($root)) {
+                try {
+                    Stop-Process -Id $proc.Id -Force -ErrorAction Stop
+                    Wait-Process -Id $proc.Id -ErrorAction SilentlyContinue -Timeout 5
+                }
+                catch {
+                    continue
+                }
+
+                break
+            }
+        }
+    }
+}

playbook/Executables/AtlasModules/Scripts/Modules/Atlas.TasksProcs/Atlas.TasksProcs.psm1

@@ -86,3 +86,71 @@ function Remove-AtlasScheduledTask {
     Invoke-AtlasScheduledTaskCommand -Path $Path -OperationLabel 'delete' -IgnoreMissing:$IgnoreMissing `
         -Arguments @('/Delete', '/TN', $Path, '/F')
 }
+
+function Stop-AtlasScheduledTaskUnderRoot {
+    param([string[]]$RootsLower)
+
+    try {
+        Import-Module ScheduledTasks -ErrorAction SilentlyContinue | Out-Null
+    }
+    catch {
+        # Module may not be available on older systems; continue with fallbacks.
+        $null = $_
+    }
+
+    $tasks = @()
+    try {
+        $tasks = Get-ScheduledTask -ErrorAction Stop
+    }
+    catch {
+        $tasks = @()
+    }
+
+    foreach ($task in $tasks) {
+        $matchesRoot = $false
+
+        foreach ($action in $task.Actions) {
+            $execute = $null
+            if ($action.PSObject.Properties.Match('Execute').Count) {
+                $execute = $action.Execute
+            }
+            elseif ($action.PSObject.Properties.Match('Path').Count) {
+                $execute = $action.Path
+            }
+
+            if (-not $execute) { continue }
+
+            $executeLower = try {
+                ([System.IO.Path]::GetFullPath($execute)).ToLowerInvariant()
+            }
+            catch {
+                $null
+            }
+
+            if (-not $executeLower) { continue }
+
+            foreach ($root in $RootsLower) {
+                if ($executeLower.StartsWith($root)) {
+                    $matchesRoot = $true
+                    break
+                }
+            }
+
+            if ($matchesRoot) { break }
+        }
+
+        if (-not $matchesRoot) { continue }
+
+        try {
+            Stop-ScheduledTask -TaskName $task.TaskName -TaskPath $task.TaskPath -ErrorAction SilentlyContinue
+        }
+        catch {
+            # Ignore and fall back to schtasks below.
+            $null = $_
+        }
+    }
+
+    foreach ($candidate in @('Force Timer Resolution', '\Force Timer Resolution')) {
+        & schtasks.exe /End /TN $candidate 1>$null 2>$null
+    }
+}

playbook/Executables/AtlasModules/Scripts/Modules/Atlas.TasksProcs/Domain/Processes.ps1

@@ -144,3 +144,21 @@ Describe 'Scheduled-task wrappers build the correct schtasks command' {
         }
     }
 }
+
+# Root-scoped process/task cleanup helpers moved here from Atlas.Core (plan 019). These assert
+# the module now owns the renamed functions and that the old Core names are gone, not aliased.
+Describe 'Root-scoped cleanup helpers live in Atlas.TasksProcs' {
+    It 'exports Stop-AtlasProcessUnderRoot and Stop-AtlasScheduledTaskUnderRoot' {
+        $exported = (Get-Command -Module Atlas.TasksProcs).Name
+        $exported | Should -Contain 'Stop-AtlasProcessUnderRoot'
+        $exported | Should -Contain 'Stop-AtlasScheduledTaskUnderRoot'
+    }
+
+    It 'no longer exposes the old Stop-ProcessesUnderRoots name' {
+        Get-Command -Name 'Stop-ProcessesUnderRoots' -ErrorAction SilentlyContinue | Should -BeNullOrEmpty
+    }
+
+    It 'no longer exposes the old Stop-TasksUnderRoots name' {
+        Get-Command -Name 'Stop-TasksUnderRoots' -ErrorAction SilentlyContinue | Should -BeNullOrEmpty
+    }
+}