refactor(config): inline services and revert shims

Services and revert only contained status writes, one phase call, and a file-level gate. Move the gates onto the custom.yml actions so AME still evaluates onUpgrade per action while preserving install order.

atlas/ now contains only AME-only configuration: start for the NO LOCAL BUILD block, components for the iso-only hive delete, appx for !appx removals, and default for the DEFAULT.reg import.

Author: jacksyrm

.github/labeler.yml

@@ -17,7 +17,8 @@ components:
 - playbook/Configuration/atlas/components.yml
 
 services:
-- playbook/Configuration/atlas/services.yml
+- playbook/Executables/AtlasModules/Scripts/Phases/Invoke-ServicesPhase.ps1
+- playbook/Executables/AtlasModules/Scripts/Modules/Atlas.Services/**/*
 
 tweaks:
 - playbook/Configuration/tweaks.yml

docs/architecture.md

@@ -12,7 +12,7 @@ This document describes how the repository is laid out and how an install runs.
 │  ├─ Configuration/         The YAML shim (thin; orchestration only)
 │  │  ├─ custom.yml          Entry point: hive lifecycle + phase calls
 │  │  ├─ tweaks.yml          Per-category Tweaks phase calls (every tweak is PowerShell)
-│  │  └─ atlas/              start / services / components / appx / default / revert
+│  │  └─ atlas/              start / components / appx / default (AME-only actions)
 │  └─ Executables/           Payload deployed to C:\Windows (AtlasModules, AtlasDesktop, Themes)
 │     └─ AtlasModules/Scripts/
 │        ├─ Invoke-AtlasInstall.ps1   Install orchestrator (one call per phase)

playbook/Configuration/atlas/revert.yml

@@ -101,11 +101,36 @@ actions:
 
   # Main tasks
   - !task: { path: 'atlas\start.yml' }
-  - !task: { path: 'atlas\services.yml' }
+
+  # Services phase (AtlasModules\Scripts\Phases\Invoke-ServicesPhase.ps1): services
+  # backup, file sharing/location/indexing configuration and the service startup list.
+  # Fresh installs only; runs as TrustedInstaller.
+  - !writeStatus: {status: 'Disabling File Sharing', onUpgrade: false}
+  - !writeStatus: {status: 'Disabling Location', onUpgrade: false}
+  - !writeStatus: {status: 'Configuring Indexing', onUpgrade: false}
+  - !writeStatus: {status: 'Configuring services', onUpgrade: false}
+  - !writeStatus: {status: 'Configuring drivers', onUpgrade: false}
+  - !powerShell:
+    command: '& (Join-Path ([Environment]::GetFolderPath(''Windows'')) ''AtlasModules\Scripts\Invoke-AtlasInstall.ps1'') -Phase Services'
+    wait: true
+    weight: 15
+    onUpgrade: false
+    handleExitCodes: { "!0": halt }
+
   - !task: { path: 'atlas\components.yml' }
   - !task: { path: 'atlas\appx.yml' }
   - !task: { path: 'atlas\default.yml' }
-  - !task: { path: 'atlas\revert.yml' }
+
+  # Revert phase (AtlasModules\Scripts\Phases\Invoke-RevertPhase.ps1): StoreFixer undoes
+  # Store breakage left by older Atlas versions. Upgrades only; runs as TrustedInstaller.
+  - !writeStatus: { status: "Reverting old changes", onUpgrade: true }
+  - !powerShell:
+    command: '& (Join-Path ([Environment]::GetFolderPath(''Windows'')) ''AtlasModules\Scripts\Invoke-AtlasInstall.ps1'') -Phase Revert'
+    weight: 2
+    wait: true
+    onUpgrade: true
+    handleExitCodes: { "!0": halt }
+
   - !task: { path: "tweaks.yml" }
 
   # Branding for upgrades (fresh installs get it via the misc tweak category)

playbook/Configuration/atlas/services.yml

@@ -1,7 +1,7 @@
 # Services phase.
 # Backs up the default Windows services, applies the scripted network/search
-# configuration and disables the curated set of services/drivers. atlas\services.yml
-# gates this phase (onUpgrade: false) and runs it as TrustedInstaller.
+# configuration and disables the curated set of services/drivers. custom.yml gates
+# this phase (onUpgrade: false) and runs it as TrustedInstaller.
 #
 # ----------------------------------
 # - Potential references           -