fix(toggles): quote relaunch argument values

Get-AtlasToggleRelaunchArgumentList quoted -LauncherPath but left -Name and
-State bare, so a value with a space or shell metacharacter would mis-split
across the Start-Process and TrustedInstaller relaunch joins. Quote them the
same way; -File binding strips the quotes on the receiving side.

Author: jacksyrm

playbook/Executables/AtlasModules/Scripts/Modules/Atlas.Toggles/Domain/Engine.ps1

@@ -222,10 +222,10 @@ function Get-AtlasToggleRelaunchArgumentList {
     $argumentList = @(
         '-NoProfile', '-NoLogo', '-ExecutionPolicy', 'Bypass',
         '-File', ('"{0}"' -f $invokeTogglePath),
-        '-Name', $Name
+        '-Name', ('"{0}"' -f $Name)
     )
     if ($State) {
-        $argumentList += @('-State', $State)
+        $argumentList += @('-State', ('"{0}"' -f $State))
     }
     if ($LauncherPath) {
         $argumentList += @('-LauncherPath', ('"{0}"' -f $LauncherPath))

tests/Atlas.Toggles.Tests.ps1

@@ -552,3 +552,48 @@ Describe 'New-ToggleLaunchers.ps1' {
         $LASTEXITCODE | Should -Be 0 -Because ($output -join "`n")
     }
 }
+
+Describe 'Get-AtlasToggleRelaunchArgumentList' {
+    # The relaunch argument list is space-joined by both consumers (Start-Process
+    # and the TrustedInstaller cmd join), so every value that can contain a space
+    # or shell metacharacter must be quoted. Get-AtlasToggleRelaunchArgumentList is
+    # module-private, hence InModuleScope.
+
+    BeforeEach {
+        Mock Get-AtlasContext -ModuleName Atlas.Toggles {
+            [pscustomobject]@{ AtlasModulesPath = 'C:\Windows\AtlasModules' }
+        }
+    }
+
+    It 'quotes the -Name value so names with spaces survive the join' {
+        InModuleScope Atlas.Toggles {
+            $list = Get-AtlasToggleRelaunchArgumentList -Name 'My Toggle' -State 'Enable'
+
+            $nameIndex = [array]::IndexOf($list, '-Name')
+            $list[$nameIndex + 1] | Should -Be '"My Toggle"'
+        }
+    }
+
+    It 'quotes the -State value when a state is supplied' {
+        InModuleScope Atlas.Toggles {
+            $list = Get-AtlasToggleRelaunchArgumentList -Name 'BackgroundApps' -State 'Disable'
+
+            $stateIndex = [array]::IndexOf($list, '-State')
+            $list[$stateIndex + 1] | Should -Be '"Disable"'
+        }
+    }
+
+    It 'produces a joined command line with no unquoted space-bearing values' {
+        InModuleScope Atlas.Toggles {
+            $list = Get-AtlasToggleRelaunchArgumentList -Name 'My Toggle' -State 'Enable Now' -LauncherPath 'C:\Program Files\x.cmd'
+
+            $joined = $list -join ' '
+
+            # Every space in the joined string must fall inside a quoted region;
+            # an odd number of quotes before any given space would reveal a bare gap.
+            $joined | Should -Match '-Name "My Toggle"'
+            $joined | Should -Match '-State "Enable Now"'
+            $joined | Should -Match '-LauncherPath "C:\\Program Files\\x.cmd"'
+        }
+    }
+}