Skip to content

Commit 1899cde

Browse files
Improve the logic to let source peers be consistent with C++ peers (maplibre#3561)
1 parent 248eb04 commit 1899cde

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

  • platform/android/MapLibreAndroid/src/main/java/org/maplibre/android/maps

platform/android/MapLibreAndroid/src/main/java/org/maplibre/android/maps/Style.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,11 @@ public <T extends Source> T getSourceAs(@NonNull String sourceId) {
160160
*/
161161
public boolean removeSource(@NonNull String sourceId) {
162162
validateState("removeSource");
163-
sources.remove(sourceId);
164-
return nativeMap.removeSource(sourceId);
163+
boolean successful = nativeMap.removeSource(sourceId);
164+
if (successful) {
165+
sources.remove(sourceId);
166+
}
167+
return successful;
165168
}
166169

167170
/**
@@ -172,8 +175,11 @@ public boolean removeSource(@NonNull String sourceId) {
172175
*/
173176
public boolean removeSource(@NonNull Source source) {
174177
validateState("removeSource");
175-
sources.remove(source.getId());
176-
return nativeMap.removeSource(source);
178+
boolean successful = nativeMap.removeSource(source);
179+
if (successful) {
180+
sources.remove(source.getId());
181+
}
182+
return successful;
177183
}
178184

179185
//

0 commit comments

Comments
 (0)