Thread doc-uri / fragment / mode separately across navigation

The client-side navigation pipeline overloaded a single $uri to mean
both "doc to fetch/cache" and "resource to display." Different
consumers silently stripped or kept different parts, surfacing as:
blank panes on fragment-bearing link clicks, mode toggles ignored
when the doc was cached, URL bar gaining a re-encoded fragment after
forth-and-back navigation across the local tab.

Split into explicit components, threaded through every entry point:

- $doc-uri (no fragment, no query) — cache key
  (LinkedDataHub.contents), tab <li> data-uri, pane @about, every
  lookup predicate. Always via ac:absolute-path.
- $fragment — the sub-anchor; lives on the outer URL per RFC 3986,
  extracted via ac:fragment-id($href). Round-tripped through tab
  @href via the 3-arity ldh:href.
- $query-params — mode/forClass/etc.; callers strip the URL fragment
  via ac:document-uri before passing to ldh:parse-query-params, so
  no caller can corrupt the last value by gluing the fragment onto it.

Touched: ldh:DocumentNavigate, ldh:RDFDocumentLoad,
ldh:rdf-document-response, ldh:RenderTab, ldh:ActivateTab,
ldh:TabSwitch, ldh:AddTabNavBarListItem; the four event handlers
(main, link click, tab click, popstate), close-tab fallback,
navbar-form, onDelete, onRDFFileUpload; modal/form callers in
bootstrap/2.3.2/client. bs2:TabBody and bs2:DocumentBody now take
@about as a mandatory param; the no-op ixsl:set-attribute workaround
(operating on a detached node after ixsl:replace-element) is removed;
layout.xsl passes @about server-side.

TabSwitch gate requires cache hit AND non-uri query params unchanged
(deep-equal vs ldh:query-params()); mode changes correctly fall
through to DocumentNavigate, so the rendered DOM gets refreshed.

ldh:query-params is now defined once (imports/default.xsl); the
client-side override that wrapped ixsl:query-params() shadowed
fragment-safe parsing and is removed. The remaining direct
ixsl:query-params() callers (ac:query stylesheet param,
navigation.xsl mode tunnel) go through ldh:query-params() too.

Anchor-emitting server templates (xhtml:Anchor, svg:Anchor,
@Rdf:resource|srx:uri) drop the encoded-full-URI fragment convention:
$fragment = ac:fragment-id(.), $href via ac:document-uri. External
resource links become ?uri=<doc-uri>#<frag> instead of
?uri=<doc-uri%23frag>#<encoded-full-uri>.

Scroll-to-fragment in RenderTab and TabSwitch uses
[@about = $resource-uri] in the active pane, replacing
id($fragment, ixsl:page()). Sidesteps the DOM-id uniqueness
constraint when two panes both render a resource at #this — the
RDFa-emitted @about is resource-URI-scoped, naturally unique.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: namedgraph

src/main/webapp/static/com/atomgraph/linkeddatahub/xsl/bootstrap/2.3.2/client/form.xsl

@@ -762,9 +762,10 @@ WHERE
             <xsl:variable name="href" select="?headers?location" as="xs:anyURI"/>
 
             <xsl:call-template name="ldh:DocumentNavigate">
-                <xsl:with-param name="uri" select="$href"/>
+                <xsl:with-param name="doc-uri" select="ac:absolute-path($href)"/>
+                <xsl:with-param name="fragment" select="ac:fragment-id($href)"/>
             </xsl:call-template>
-        </xsl:for-each>        
+        </xsl:for-each>
     </xsl:function>
 
     <xsl:function name="ldh:row-form-submit-violation" ixsl:updating="yes">

src/main/webapp/static/com/atomgraph/linkeddatahub/xsl/bootstrap/2.3.2/client/functions.xsl

@@ -41,9 +41,7 @@ exclude-result-prefixes="#all"
         <xsl:sequence select="xs:anyURI(ixsl:location())"/>
     </xsl:function>
 
-    <xsl:function name="ldh:query-params" as="map(xs:string, xs:string*)">
-        <xsl:sequence select="ixsl:query-params()"/>
-    </xsl:function>
+    <!-- ldh:query-params is defined once in imports/default.xsl and works in both contexts via ldh:request-uri -->
 
     <xsl:function name="ldh:base-uri" as="xs:anyURI">
         <xsl:param name="arg" as="node()"/> <!-- ignored -->

src/main/webapp/static/com/atomgraph/linkeddatahub/xsl/bootstrap/2.3.2/client/modal.xsl

@@ -1272,7 +1272,8 @@ LIMIT   10
                 <xsl:variable name="form" select="$context('form')" as="element()?"/>
                 <xsl:sequence select="ixsl:call($form/ancestor::div[contains-token(@class, 'modal')], 'remove', [])[current-date() lt xs:date('2000-01-01')]"/>
                 <xsl:call-template name="ldh:DocumentNavigate">
-                    <xsl:with-param name="uri" select="$doc-uri"/>
+                    <xsl:with-param name="doc-uri" select="$doc-uri"/>
+                    <xsl:with-param name="fragment" select="()"/>
                 </xsl:call-template>
             </xsl:when>
             <xsl:when test="$status = 201 and map:contains($response?headers, 'location')">
@@ -1571,7 +1572,8 @@ LIMIT   10
                 <xsl:sequence select="ixsl:call($form/ancestor::div[contains-token(@class, 'modal')], 'remove', [])[current-date() lt xs:date('2000-01-01')]"/>
 
                 <xsl:call-template name="ldh:DocumentNavigate">
-                    <xsl:with-param name="uri" select="ac:absolute-path($uri)"/>
+                    <xsl:with-param name="doc-uri" select="ac:absolute-path($uri)"/>
+                    <xsl:with-param name="fragment" select="ac:fragment-id($uri)"/>
                 </xsl:call-template>
             </xsl:when>
             <!-- Error -->
@@ -1598,7 +1600,8 @@ LIMIT   10
                 <xsl:sequence select="ixsl:call($form/ancestor::div[contains-token(@class, 'modal')], 'remove', [])[current-date() lt xs:date('2000-01-01')]"/>
 
                 <xsl:call-template name="ldh:DocumentNavigate">
-                    <xsl:with-param name="uri" select="ac:absolute-path($uri)"/>
+                    <xsl:with-param name="doc-uri" select="ac:absolute-path($uri)"/>
+                    <xsl:with-param name="fragment" select="ac:fragment-id($uri)"/>
                 </xsl:call-template>
             </xsl:when>
             <!-- Error: render error message inline in the form's fieldset -->

src/main/webapp/static/com/atomgraph/linkeddatahub/xsl/bootstrap/2.3.2/client/navigation.xsl

@@ -667,7 +667,7 @@ ORDER BY DESC(?created)
                             <ul class="well well-small nav nav-list">
                                 <xsl:apply-templates select="$results/rdf:RDF/rdf:Description[not(@rdf:about = $doc-uri)]" mode="xhtml:ListItem">
                                     <xsl:sort select="ac:label(.)" order="ascending" lang="{$ldt:lang}"/>
-                                    <xsl:with-param name="mode" select="ixsl:query-params()?mode[1]" tunnel="yes"/> <!-- TO-DO: support multiple modes -->
+                                    <xsl:with-param name="mode" select="ldh:query-params()?mode[1]" tunnel="yes"/> <!-- TO-DO: support multiple modes -->
                                     <xsl:with-param name="render-id" select="false()" tunnel="yes"/>
                                 </xsl:apply-templates>
                             </ul>

src/main/webapp/static/com/atomgraph/linkeddatahub/xsl/bootstrap/2.3.2/document.xsl

@@ -419,6 +419,7 @@ extension-element-prefixes="ixsl"
         <xsl:param name="base" as="xs:anyURI?"/>
         <xsl:param name="endpoint" as="xs:anyURI?"/>
         <xsl:param name="application" as="xs:anyURI?"/>
+        <xsl:param name="about" as="xs:anyURI"/>
         <xsl:param name="object-metadata" as="document-node()?" tunnel="yes"/>
 
         <div>
@@ -444,6 +445,7 @@ extension-element-prefixes="ixsl"
 
             <xsl:apply-templates select="." mode="bs2:DocumentBody">
                 <xsl:with-param name="mode" select="$mode"/>
+                <xsl:with-param name="about" select="$about"/>
             </xsl:apply-templates>
         </div>
     </xsl:template>
@@ -454,7 +456,7 @@ extension-element-prefixes="ixsl"
         <xsl:param name="id" as="xs:string?"/>
         <xsl:param name="class" select="'document-body'" as="xs:string?"/>
         <xsl:param name="mode" as="xs:anyURI"/>
-        <xsl:param name="about" select="ac:absolute-path(ldh:base-uri(.))" as="xs:anyURI"/>
+        <xsl:param name="about" as="xs:anyURI"/>
         <xsl:param name="object-metadata" as="document-node()?" tunnel="yes"/>
 
         <div>
@@ -464,9 +466,7 @@ extension-element-prefixes="ixsl"
             <xsl:if test="$class">
                 <xsl:attribute name="class" select="$class"/>
             </xsl:if>
-            <xsl:if test="$about">
-                <xsl:attribute name="about" select="$about"/>
-            </xsl:if>
+            <xsl:attribute name="about" select="$about"/>
 
             <xsl:apply-templates select="." mode="bs2:ActionBar">
                 <xsl:with-param name="active-mode" select="$mode"/>

src/main/webapp/static/com/atomgraph/linkeddatahub/xsl/bootstrap/2.3.2/imports/default.xsl

@@ -161,7 +161,8 @@ exclude-result-prefixes="#all"
     </xsl:function>
 
     <xsl:function name="ldh:query-params" as="map(xs:string, xs:string*)">
-        <xsl:sequence select="ldh:parse-query-params(substring-after(ldh:request-uri(), '?'))"/>
+        <!-- ac:document-uri strips the URL's #fragment so it doesn't get glued onto the last query value -->
+        <xsl:sequence select="ldh:parse-query-params(substring-after(ac:document-uri(ldh:request-uri()), '?'))"/>
     </xsl:function>
 
     <xsl:function name="ldh:base-uri" as="xs:anyURI" use-when="system-property('xsl:product-name') = 'SAXON'">
@@ -329,7 +330,7 @@ exclude-result-prefixes="#all"
 
     <xsl:function name="ldh:parse-query-params" as="map(xs:string, xs:string*)">
         <xsl:param name="query-string" as="xs:string"/>
-        
+
         <xsl:sequence select="map:merge(
             tokenize($query-string, '&amp;')[normalize-space()]
             !
@@ -534,8 +535,8 @@ exclude-result-prefixes="#all"
     <!-- subject resource -->
     <xsl:template match="@rdf:about" mode="xhtml:Anchor">
 <!--        <xsl:param name="graph" as="xs:anyURI?" tunnel="yes"/>-->
-        <xsl:param name="fragment" select="if (starts-with(., ldt:base())) then (if (contains(., '#')) then substring-after(., '#') else ()) else encode-for-uri(.)" as="xs:string?"/>
-        <xsl:param name="href" select="ldh:href(xs:anyURI(.), map{}, $fragment)" as="xs:anyURI"/>
+        <xsl:param name="fragment" select="ac:fragment-id(.)" as="xs:string?"/>
+        <xsl:param name="href" select="ldh:href(ac:document-uri(xs:anyURI(.)), map{}, $fragment)" as="xs:anyURI"/>
         <xsl:param name="id" as="xs:string?"/>
         <xsl:param name="title" select="." as="xs:string?"/>
         <xsl:param name="class" as="xs:string?"/>
@@ -551,8 +552,8 @@ exclude-result-prefixes="#all"
     </xsl:template>
 
     <xsl:template match="@rdf:about | @rdf:resource" mode="svg:Anchor">
-        <xsl:param name="fragment" select="if (starts-with(., ldt:base())) then (if (contains(., '#')) then substring-after(., '#') else ()) else encode-for-uri(.)" as="xs:string?"/>
-        <xsl:param name="href" select="ldh:href(xs:anyURI(.), map{}, $fragment)" as="xs:anyURI"/>
+        <xsl:param name="fragment" select="ac:fragment-id(.)" as="xs:string?"/>
+        <xsl:param name="href" select="ldh:href(ac:document-uri(xs:anyURI(.)), map{}, $fragment)" as="xs:anyURI"/>
         <xsl:param name="id" select="$fragment" as="xs:string?"/>
         <xsl:param name="label" select="if (parent::rdf:Description) then ac:svg-label(..) else ac:svg-object-label(.)" as="xs:string"/>
         <xsl:param name="title" select="$label" as="xs:string"/>
@@ -573,8 +574,8 @@ exclude-result-prefixes="#all"
 
     <!-- proxy link URIs if they are external -->
     <xsl:template match="@rdf:resource | srx:uri" priority="2">
-        <xsl:param name="fragment" select="if (starts-with(., ldt:base())) then (if (contains(., '#')) then substring-after(., '#') else ()) else encode-for-uri(.)" as="xs:string?"/>
-        <xsl:param name="href" select="ldh:href(xs:anyURI(.), map{}, $fragment)" as="xs:anyURI"/>
+        <xsl:param name="fragment" select="ac:fragment-id(.)" as="xs:string?"/>
+        <xsl:param name="href" select="ldh:href(ac:document-uri(xs:anyURI(.)), map{}, $fragment)" as="xs:anyURI"/>
         <xsl:param name="id" as="xs:string?"/>
         <xsl:param name="title" select="." as="xs:string?"/>
         <xsl:param name="class" as="xs:string?"/>

src/main/webapp/static/com/atomgraph/linkeddatahub/xsl/bootstrap/2.3.2/layout.xsl

@@ -758,6 +758,7 @@ exclude-result-prefixes="#all">
                             <xsl:with-param name="mode" select="ac:mode(root())"/>
                             <xsl:with-param name="base" select="ldt:base()"/>
                             <xsl:with-param name="endpoint" select="sd:endpoint()"/>
+                            <xsl:with-param name="about" select="ac:absolute-path(ldh:base-uri(.))"/>
                             <xsl:with-param name="object-metadata" select="$object-metadata" tunnel="yes"/>
                         </xsl:apply-templates>
                     </div>