Closing client responss

HTTP test fixes

Author: namedgraph

CLAUDE.md

@@ -112,4 +112,26 @@ export PATH="$(find bin -type d -exec realpath {} \; | tr '\n' ':')$PATH"
 - XSLT stylesheets are processed during build to inline XML entities
 - Saxon-JS SEF files are generated during Maven package phase for client-side XSLT
 - WebID certificates are required for authenticated API access
-- The system expects Jena CLI tools to be available (`JENA_HOME` environment variable)
+- The system expects Jena CLI tools to be available (`JENA_HOME` environment variable)
+
+## Debugging Test Failures
+
+When HTTP tests fail:
+1. NEVER speculate about failures - always add debug output first
+2. Add echo statements showing:
+    - The actual values being tested
+    - The expected values
+    - HTTP response codes and bodies where relevant
+3. Run the test to see actual output
+4. Only then diagnose and fix
+
+Example debug pattern:
+```bash
+result=$(curl ...)
+expected="..."
+echo "DEBUG: Expected: $expected"
+echo "DEBUG: Got: $result"
+if [ "$result" != "$expected" ]; then
+echo "DEBUG: Mismatch!"
+exit 1
+fi

http-tests/admin/GET-agent-mbox-html.sh

@@ -14,7 +14,9 @@ html=$(curl -k -f -s -N \
 
 # check that the description does *not* include foaf:mbox property
 
-echo "$html" | grep -v "http://xmlns.com/foaf/0.1/mbox" > /dev/null
+if echo "$html" | grep -q "http://xmlns.com/foaf/0.1/mbox"; then
+  exit 1
+fi
 
 # check that the description includes foaf:mbox_sha1sum property
 

http-tests/document-hierarchy/PUT-twice.sh

@@ -52,9 +52,12 @@ EOF
 
 # check that the old document metadata is gone
 
-curl -k -f -s -G \
+response=$(curl -k -f -s -G \
   -E "$AGENT_CERT_FILE":"$AGENT_CERT_PWD" \
   -H "Accept: application/n-triples" \
   "$END_USER_BASE_URL" \
-| tr -d '\n' \
-| grep -v '"old object"' > /dev/null
+| tr -d '\n')
+
+if echo "$response" | grep -q '"old object"'; then
+  exit 1
+fi

src/main/java/com/atomgraph/linkeddatahub/resource/Generate.java

@@ -159,8 +159,11 @@ public Response post(Model model, @QueryParam("default") @DefaultValue("false")
             }
 
             // ban the parent container URI from proxy cache to make sure the next query using it will be fresh (e.g. SELECT that loads children)
-            ban(getApplication().getService().getBackendProxy(), parent.getURI());
-            
+            try (Response response = ban(getApplication().getService().getBackendProxy(), parent.getURI()))
+            {
+                // Response automatically closed by try-with-resources
+            }
+
             return Response.ok().build();
         }
         finally

src/main/java/com/atomgraph/linkeddatahub/resource/admin/SignUp.java

@@ -288,7 +288,13 @@ public Response post(Model agentModel, @QueryParam("default") @DefaultValue("fal
                 }
 
                 // purge agent lookup from proxy cache
-                if (getAgentService().getBackendProxy() != null) ban(getAgentService().getBackendProxy(), mbox.getURI());
+                if (getAgentService().getBackendProxy() != null)
+                {
+                    try (Response response = ban(getAgentService().getBackendProxy(), mbox.getURI()))
+                    {
+                        // Response automatically closed by try-with-resources
+                    }
+                }
 
                 // remove secretary WebID from cache
                 getSystem().getEventBus().post(new com.atomgraph.linkeddatahub.server.event.SignUp(getSystem().getSecretaryWebIDURI()));