Merged
Conversation
) * Exempt proxy requests from local ACL checks in AuthorizationFilter Document-centric ACL (acl:accessTo <document>) is semantically wrong for the proxy, which is a global transport function. Requiring acl:Write on a local document to forward a DELETE to a remote target would be a security anti-pattern — the target endpoint enforces its own access control, and SSRF protection via URLValidator is the appropriate security layer. Extends the existing mapped-URI bypass to cover all methods and all URIs when ?uri= is present. Adds a regression test that verifies an agent with acl:Append only on /sparql (not on the root URL) can POST via proxy. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Move proxy logic from ProxiedGraph into ProxyRequestFilter Replace the JAX-RS sub-resource (ProxiedGraph) and Dispatcher routing with a @PreMatching ContainerRequestFilter (priority 4050) that intercepts all proxy requests — both explicit ?uri= params and lapp:Dataset matches — before AuthorizationFilter runs. ACL is no longer checked for proxy requests; access control is enforced by the target endpoint. Removes the proxy bypass hack from AuthorizationFilter and simplifies Dispatcher (no more getProxyClass()). ProxiedGraph is deleted entirely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Set REQUEST_URI_HEADER on proxy client response before entity read ModelProvider / HtmlJsonLDReader requires a base URI hint (set via REQUEST_URI_HEADER on the response) to resolve relative references when parsing HTML+JSON-LD. Without it jsoup throws a NullPointerException. Mirrors the header injection done in the old ProxiedGraph.get(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Disable proxy test suite run (test removed, no proxy tests remain) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
The ldh:RenderFacets named template was unconditionally appending a div.well.well-small into div.left-nav even when the SPARQL query had no qualifying BGP triples, causing an empty grey box to appear. The fix moves bgp-triples-map computation before the guard and conditions the append on exists($bgp-triples-map), leaving the server-rendered empty div.left-nav unstyled when there are no facets to show. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Reverts the accidental commenting-out of test suites introduced in 2c82919. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.