Skip to content

build: changes needed for testground e2e test#567

Merged
jorgeantonio21 merged 14 commits into
AtomaAI:mainfrom
maschad:mc/build/testground-changes
Apr 21, 2025
Merged

build: changes needed for testground e2e test#567
jorgeantonio21 merged 14 commits into
AtomaAI:mainfrom
maschad:mc/build/testground-changes

Conversation

@maschad
Copy link
Copy Markdown
Member

@maschad maschad commented Apr 15, 2025

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

docker-compose.dev.yaml:266

  • [nitpick] The container name 'chat-completions1' appears to deviate from previous naming conventions. Consider confirming the naming pattern for clarity and consistency across similar services.
container_name: chat-completions1

Comment thread atoma-p2p/src/service.rs
@maschad maschad force-pushed the mc/build/testground-changes branch from 310c249 to 76ac61c Compare April 16, 2025 00:47
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.77%. Comparing base (0f1cae0) to head (794cd4c).
Report is 162 commits behind head on main.

Files with missing lines Patch % Lines
atoma-p2p/src/service.rs 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
+ Coverage   64.68%   65.77%   +1.09%     
==========================================
  Files          53       54       +1     
  Lines        9534    10327     +793     
==========================================
+ Hits         6167     6793     +626     
- Misses       3367     3534     +167     
Files with missing lines Coverage Δ
atoma-p2p/src/config.rs 0.00% <ø> (ø)
atoma-p2p/src/service.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maschad maschad force-pushed the mc/build/testground-changes branch from 1f7ae17 to 854ff2a Compare April 16, 2025 02:58
@maschad maschad marked this pull request as ready for review April 16, 2025 18:59
@maschad maschad requested review from Cifko and jorgeantonio21 April 16, 2025 19:00
@maschad maschad changed the title build: changed needed for testground build: changes needed for testground e2e test Apr 16, 2025
@maschad maschad marked this pull request as draft April 17, 2025 15:28
@maschad maschad marked this pull request as ready for review April 17, 2025 21:41
Copy link
Copy Markdown
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a few comments to make sure everything is aligned and then we can merge.

Comment thread atoma-p2p/src/config.rs
Comment thread config.example.toml
Comment thread docker-compose.dev.yaml
@maschad maschad requested a review from jorgeantonio21 April 19, 2025 16:07
@jorgeantonio21 jorgeantonio21 merged commit d59ea1f into AtomaAI:main Apr 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants