build: changes needed for testground e2e test#567
Merged
jorgeantonio21 merged 14 commits intoApr 21, 2025
Conversation
Member
maschad
commented
Apr 15, 2025
- Related to build: add workflow for AWS hosted instances on e2e test atoma-testground#17
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
docker-compose.dev.yaml:266
- [nitpick] The container name 'chat-completions1' appears to deviate from previous naming conventions. Consider confirming the naming pattern for clarity and consistency across similar services.
container_name: chat-completions1
310c249 to
76ac61c
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #567 +/- ##
==========================================
+ Coverage 64.68% 65.77% +1.09%
==========================================
Files 53 54 +1
Lines 9534 10327 +793
==========================================
+ Hits 6167 6793 +626
- Misses 3367 3534 +167
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
1f7ae17 to
854ff2a
Compare
Contributor
jorgeantonio21
left a comment
There was a problem hiding this comment.
Looking good, left a few comments to make sure everything is aligned and then we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.