fix(llamacpp-upstream): backend path resolution, tests, and reasoning toggle#124
Open
yanalialiuk wants to merge 6 commits into
Open
fix(llamacpp-upstream): backend path resolution, tests, and reasoning toggle#124yanalialiuk wants to merge 6 commits into
yanalialiuk wants to merge 6 commits into
Conversation
…op-level folder isBackendInstalled/getBackendExePath only checked <dir>/build/bin/llama-server and <dir>/llama-server. ggml-org ubuntu tarballs can unpack with an extra top-level folder, so the exe lands deeper and detection fails -> UI shows the backend as not installed and re-prompts download in a loop. Add a bounded recursive fallback that locates llama-server at any depth. Applied to both the upstream and turboquant extensions; adds a regression test.
…aude Code + strict templates)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up after #108 (IDE integrations). Four focused commits rebased on current
main:llama-serverwhen archive unpacks with an extra top-level folder (bothllamacppandllamacpp-upstreambackends)llamacpp→llamacpp-upstreambackend paths in unit testsfetchcall-count assertion after proxy-aware fetch pathChanges
extensions/llamacpp-extension/src/backend.ts,extensions/llamacpp-upstream-extension/src/backend.tsextensions/llamacpp-upstream-extension/src/test/backend.test.tsReasoningToggle.tsx,MessageItem.tsx,custom-chat-transport.ts,useGeneralSetting.ts,common.jsonTest plan
yarn test:run src/test/backend.test.tsinextensions/llamacpp-upstream-extension(10/10 passed)llama-serverstartsMade with Cursor