fix(models): de-dupe favorites by model id (nickname no longer lists a model twice)#138
Open
yanalialiuk wants to merge 1 commit into
Open
fix(models): de-dupe favorites by model id (nickname no longer lists a model twice)#138yanalialiuk wants to merge 1 commit into
yanalialiuk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llamacpp+llamacpp-upstream), favorites now collapse to a single entry instead of showing twice after nicknaming.model.displayName); otherwise keep the first match.Problem
Favorites are keyed by model id, but
searchableItemscan include the same id from more than one provider. Nicknaming one copy caused the favorite list to show the model twice — once with the nickname and once with the raw id.Test plan
Made with Cursor