fix(launch): move Poolside EULA env var to the right side of the pipe#150
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(launch): move Poolside EULA env var to the right side of the pipe#150cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
POOL_INSTALL_ACCEPT_EULA=1 prefixed curl (the left side of `curl | sh`), so the env var scoped only to curl and never reached the sh process that actually runs install.sh. The installer then saw ACCEPT_EULA=0, prompted for interactive EULA confirmation, tried to read /dev/tty (no TTY when spawned from the GUI), and failed with 'installation canceled'. Move the assignment to prefix sh instead, so the installer script itself sees POOL_INSTALL_ACCEPT_EULA=1 and skips the prompt. Matches the existing goose entry's pattern (env var on the interpreter side of the pipe). Windows branch is unaffected (single process, no pipe). Fixes ATO-269. Co-authored-by: Mike <Vect0rM@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
In
agent_install_spec()(src-tauri/src/core/system/commands.rs), the Unix install command for the Poolside agent was:POOL_INSTALL_ACCEPT_EULA=1 curl -fsSL https://downloads.poolside.ai/pool/install.sh | shIn a shell pipeline
A | B, a leadingVAR=1scopes only to the command it prefixes. HerePOOL_INSTALL_ACCEPT_EULA=1prefixedcurl(the left side of the pipe), while the installer script actually runs inside the separateshprocess on the right side of the pipe — which never inherits that assignment.The installer's
install.shreadsACCEPT_EULA="${POOL_INSTALL_ACCEPT_EULA:-0}"(defaults to0) and, when unset/0, promptsContinue? [Y/n]by reading/dev/tty. Since the process is spawned from the GUI app with no TTY attached, this fails withsh: line 126: /dev/tty: Device not configured→Error: installation canceled, and the install toast showsFailed to install Poolside.The env var name is correct; only its position in the pipeline was wrong. The neighboring
gooseentry already does this correctly (... | CONFIGURE=false bash— variable on the interpreter side of the pipe), and the Windows branch of Poolside ($env:POOL_INSTALL_ACCEPT_EULA='1'; irm ... | iex) is unaffected since it's a single PowerShell process, not a pipe between two processes.Fix
Move the assignment to the right side of the pipe, prefixing
sh(the process that actually executesinstall.shand reads the env var) instead ofcurl:curl -fsSL https://downloads.poolside.ai/pool/install.sh | POOL_INSTALL_ACCEPT_EULA=1 shOne-line change, Unix branch only (macOS/Linux). Windows branch untouched.
Verification
cargo check -p Atomic-Chatcompiles cleanly (0 errors; only pre-existing, unrelateddead_codewarnings in the llamacpp/llamacpp-upstream/vector-db plugins).Closes ATO-269.