make regular expression object static

in1tiate · in1tiate · commit 0bd3ddf7f0a1 · 2025-01-11T02:17:51.000-06:00
diff --git a/src/aoutils.cpp b/src/aoutils.cpp
@@ -46,7 +46,7 @@ void AOUtils::migrateEffects(QSettings &p_effects_ini)
   // realization_scaling - This would not be appended to the key_list as it matches scaling property.
   // realization_alt - This would be appened as it contains an underscore, but not a property.
   // hearts - This would be appended as it does not contain a property
-  const QRegularExpression l_regex(QStringLiteral("(\\w+)_(%1)$").arg(l_property_list.join("|")));
+  static QRegularExpression l_regex(QStringLiteral("(\\w+)_(%1)$").arg(l_property_list.join("|")));
   for (auto i = l_effect_map.begin(); i != l_effect_map.end(); i++)
   {
     if (l_regex.match(i.key()).hasMatch())

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ void AOUtils::migrateEffects(QSettings &p_effects_ini)`
`46`	`46`	`// realization_scaling - This would not be appended to the key_list as it matches scaling property.`
`47`	`47`	`// realization_alt - This would be appened as it contains an underscore, but not a property.`
`48`	`48`	`// hearts - This would be appended as it does not contain a property`
`49`		`- const QRegularExpression l_regex(QStringLiteral("(\\w+)_(%1)$").arg(l_property_list.join("\|")));`
	`49`	`+ static QRegularExpression l_regex(QStringLiteral("(\\w+)_(%1)$").arg(l_property_list.join("\|")));`
`50`	`50`	`for (auto i = l_effect_map.begin(); i != l_effect_map.end(); i++)`
`51`	`51`	`{`
`52`	`52`	`if (l_regex.match(i.key()).hasMatch())`