Fix logging (#1118)

* not a demo server OR demo logging enabled

* dont always create the demo server

* stray space

---------

Co-authored-by: in1tiate <32779090+in1tiate@users.noreply.github.com>

Author: stonedDiscord

src/aoapplication.cpp

@@ -62,7 +62,7 @@ void AOApplication::construct_lobby()
   {
     demo_server->deleteLater();
   }
-  demo_server = new DemoServer(this);
+
   w_lobby->show();
 }
 

src/lobby.cpp

@@ -433,13 +433,19 @@ void Lobby::on_demo_clicked(QTreeWidgetItem *item, int column)
     return;
   }
 
+  if (ao_app->demo_server)
+  {
+    ao_app->demo_server->deleteLater();
+  }
+  ao_app->demo_server = new DemoServer(this);
+
   QString l_filepath = (get_app_path() + "/logs/%1/%2").arg(item->data(0, Qt::DisplayRole).toString(), item->data(1, Qt::DisplayRole).toString());
   ao_app->demo_server->start_server();
-  ServerInfo demo_server;
-  demo_server.address = "127.0.0.1";
-  demo_server.port = ao_app->demo_server->port();
+  ServerInfo demo_server_connection;
+  demo_server_connection.address = "127.0.0.1";
+  demo_server_connection.port = ao_app->demo_server->port();
   ao_app->demo_server->set_demo_file(l_filepath);
-  net_manager->connect_to_server(demo_server);
+  net_manager->connect_to_server(demo_server_connection);
 }
 
 void Lobby::onReloadThemeRequested()

src/packet_distribution.cpp

@@ -167,7 +167,7 @@ void AOApplication::server_packet_received(AOPacket packet)
 
     QString server_name_stripped = server_name;
     static QRegularExpression illegal_filename_chars("[\\\\/:*?\"<>|\']");
-    if (Options::getInstance().logToDemoFileEnabled() && !demo_server)
+    if (Options::getInstance().logToDemoFileEnabled() || !demo_server)
     {
       this->log_filename = QDateTime::currentDateTime().toUTC().toString("'logs/" + server_name_stripped.remove(illegal_filename_chars) + "/'yyyy-MM-dd hh-mm-ss t'.log'");
       this->write_to_file("Joined server " + server_name_stripped + " hosted on address " + server_address + " on " + QDateTime::currentDateTime().toUTC().toString(), log_filename, true);