avoid loop container detach

in1tiate · in1tiate · commit 2389ecfa976d · 2025-01-11T02:27:35.000-06:00
diff --git a/src/courtroom.cpp b/src/courtroom.cpp
@@ -1407,7 +1407,7 @@ void Courtroom::set_background(QString p_background, bool display)
 
   // Populate the dropdown list with all pos that exist on this bg
   QStringList pos_list = {};
-  for (const QString &key : default_pos)
+  for (const QString &key : std::as_const(default_pos))
   {
     if (file_exists(ao_app->get_image_suffix(ao_app->get_background_path(default_pos[key]))) || // if we have 2.8-style positions, e.g. def.png, wit.webp, hld.apng
         file_exists(ao_app->get_image_suffix(ao_app->get_background_path(key))))

Original file line number	Diff line number	Diff line change
`@@ -1407,7 +1407,7 @@ void Courtroom::set_background(QString p_background, bool display)`
`1407`	`1407`
`1408`	`1408`	`// Populate the dropdown list with all pos that exist on this bg`
`1409`	`1409`	`QStringList pos_list = {};`
`1410`		`- for (const QString &key : default_pos)`
	`1410`	`+ for (const QString &key : std::as_const(default_pos))`
`1411`	`1411`	`{`
`1412`	`1412`	`if (file_exists(ao_app->get_image_suffix(ao_app->get_background_path(default_pos[key]))) \|\| // if we have 2.8-style positions, e.g. def.png, wit.webp, hld.apng`
`1413`	`1413`	`file_exists(ao_app->get_image_suffix(ao_app->get_background_path(key))))`