Skip to content

Commit 501f2a9

Browse files
committed
fix static regexps
1 parent 23467ce commit 501f2a9

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/lobby.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ Lobby::Lobby(AOApplication *p_ao_app, NetworkManager *p_net_manager)
2020
{
2121
reloadUi();
2222
setObjectName("lobby");
23-
regexp_links = QRegularExpression("\\b(https?://\\S+\\.\\S+)\\b");
2423
}
2524

2625
void Lobby::on_tab_changed(int index)
@@ -564,6 +563,8 @@ void Lobby::check_for_updates()
564563
QVersionNumber current_version = QVersionNumber::fromString(ao_app->get_version_string());
565564
QVersionNumber master_version = QVersionNumber::fromString(version);
566565

566+
static QRegularExpression regexp_links("\\b(https?://\\S+\\.\\S+)\\b");
567+
567568
if (current_version < master_version)
568569
{
569570
ui_game_version_lbl->setText(tr("Version: %1 [OUTDATED]").arg(current_version.toString()));
@@ -584,6 +585,7 @@ void Lobby::set_player_count(int players_online, int max_players)
584585
void Lobby::set_server_description(const QString &server_description)
585586
{
586587
ui_server_description_text->clear();
588+
static QRegularExpression regexp_links("\\b(https?://\\S+\\.\\S+)\\b");
587589
QString result = server_description.toHtmlEscaped().replace("\n", "<br>").replace(regexp_links, "<a href='\\1'>\\1</a>");
588590
ui_server_description_text->insertHtml(result);
589591
}

src/lobby.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,6 @@ class Lobby : public QMainWindow
9191
// Optional Widget
9292
QTextBrowser *ui_game_changelog_text;
9393

94-
static QRegularExpression regexp_links;
95-
9694
void loadUI();
9795
void reloadUi();
9896

0 commit comments

Comments
 (0)