avoid detaching temporary container

in1tiate · in1tiate · commit a7d292b8b673 · 2025-01-11T02:19:46.000-06:00
diff --git a/src/charselect.cpp b/src/charselect.cpp
@@ -352,7 +352,7 @@ void Courtroom::filter_character_list()
   for (int i = 0; i < char_list.size(); i++)
   {
     AOCharButton *current_char = ui_char_button_list.at(i);
-    QTreeWidgetItem *current_char_list_item = ui_char_list->findItems(QString::number(i), Qt::MatchExactly | Qt::MatchRecursive, 1)[0];
+    QTreeWidgetItem *current_char_list_item = ui_char_list->findItems(QString::number(i), Qt::MatchExactly | Qt::MatchRecursive, 1).at(0);
 
     // It seems passwording characters is unimplemented yet?
     // Until then, this will stay here, I suppose.

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,7 @@ void Courtroom::filter_character_list()`
`352`	`352`	`for (int i = 0; i < char_list.size(); i++)`
`353`	`353`	`{`
`354`	`354`	`AOCharButton *current_char = ui_char_button_list.at(i);`
`355`		`- QTreeWidgetItem *current_char_list_item = ui_char_list->findItems(QString::number(i), Qt::MatchExactly \| Qt::MatchRecursive, 1)[0];`
	`355`	`+ QTreeWidgetItem *current_char_list_item = ui_char_list->findItems(QString::number(i), Qt::MatchExactly \| Qt::MatchRecursive, 1).at(0);`
`356`	`356`
`357`	`357`	`// It seems passwording characters is unimplemented yet?`
`358`	`358`	`// Until then, this will stay here, I suppose.`