Addressing test instability

Author: aure

Sources/Soundpipe/modules/custom/circular_buffer.c

@@ -4,7 +4,10 @@
 #include "circular_buffer.h"
 
 void cb_init(circular_buffer *cb, size_t capacity, size_t sz) {
-    cb->buffer = malloc(capacity * sz);
+    // calloc: pitchcalculate/pitchcorrect read via cb_read_at_index_behind_write
+    // before the buffer has been fully populated; zeroing prevents those early
+    // reads from returning allocator-state-dependent garbage.
+    cb->buffer = calloc(capacity, sz);
     if(cb->buffer == NULL)
         // handle error
     cb->buffer_end = (char *)cb->buffer + capacity * sz;

Sources/Soundpipe/modules/custom/pitchcalculate.c

@@ -7,7 +7,10 @@
 #include <stdio.h>
 
 int pitchcalculate_create(pitchcalculate **p) {
-    *p = malloc(sizeof(pitchcalculate));
+    // calloc: pitchcalculate_init does not set asdf_offset or cur_period;
+    // pitchcalculate_compute reads them before initial_freq is ever valid,
+    // so zeroing avoids allocator-state-dependent output across tests.
+    *p = calloc(1, sizeof(pitchcalculate));
     return SP_OK;
 }
 

Sources/Soundpipe/modules/custom/pitchcorrect.c

@@ -12,7 +12,11 @@ float min_freq = 20.0;
 float max_freq = 3000.0;
 
 int pitchcorrect_create(pitchcorrect **p) {
-    *p = malloc(sizeof(pitchcorrect));
+    // calloc: pitchcorrect_init does not assign every field (e.g.
+    // should_update_scale_freqs, should_smooth_target_freq,
+    // nearest_scale_freq_index, target_freq, tmp_scale_freqs*), and the
+    // compute path reads them. Zeroing here avoids order-dependent output.
+    *p = calloc(1, sizeof(pitchcorrect));
     return SP_OK;
 }
 

Sources/Soundpipe/modules/custom/pitchshift2.c

@@ -9,7 +9,9 @@ float delay_window = 75.;
 float pi = 3.1415926535;
 
 int pitchshift2_create(pitchshift2 **p) {
-    *p = malloc(sizeof(pitchshift2));
+    // calloc: pitchshift2_init leaves several fields unset (e.g. playhead_incr,
+    // window_advance, fader_target). Zeroing avoids heap-state-dependent output.
+    *p = calloc(1, sizeof(pitchshift2));
     return SP_OK;
 }
 

Tests/SoundpipeAudioKitTests/Effects Tests/PitchShifterTests.swift

@@ -14,6 +14,5 @@ class PitchShifterTests: XCTestCase {
         input.start()
         let audio = engine.startTest(totalDuration: 1.0)
         audio.append(engine.render(duration: 1.0))
-        audio.audition()
     }
 }