Core implementation of the Generic Tree View feature#29
Merged
ramesh521 merged 6 commits intoJul 15, 2026
Merged
Conversation
ramesh521
self-requested a review
July 10, 2026 04:51
satyakris
added a commit
to satyakris/audioreach-creator-ui
that referenced
this pull request
Jul 10, 2026
Fix tag-data API endpoint documentation to use the correct
two-segment path (tag-data/{tagSystemId}/{tkvSystemId}) matching
swagger and implementation.
Also close a design gap found in PR AudioReach#29 review (finding AudioReach#3):
FR-GS-02 previously specified the same full reseed-and-clear for
both Get and Set, which meant setPaths could never be populated.
Rewrite FR-GS-02/FR-ST-05 and design.md Sec 9.6, and add Sec 9.7,
to specify that Set instead merges the (possibly partial) backend
response into the existing DTO and reconciles dirty/set state
per-path, leaving Get's full reseed unchanged.
Signed-off-by: Satya Krishna Pindiproli <satyak@qti.qualcomm.com>
satyakris
force-pushed
the
feature/gtv-implementation
branch
from
July 10, 2026 13:02
e17954d to
11a784a
Compare
ramesh521
reviewed
Jul 14, 2026
ramesh521
reviewed
Jul 14, 2026
satyakris
added a commit
to satyakris/audioreach-creator-ui
that referenced
this pull request
Jul 14, 2026
Fix tag-data API endpoint documentation to use the correct
two-segment path (tag-data/{tagSystemId}/{tkvSystemId}) matching
swagger and implementation.
Also close a design gap found in PR AudioReach#29 review (finding AudioReach#3):
FR-GS-02 previously specified the same full reseed-and-clear for
both Get and Set, which meant setPaths could never be populated.
Rewrite FR-GS-02/FR-ST-05 and design.md Sec 9.6, and add Sec 9.7,
to specify that Set instead merges the (possibly partial) backend
response into the existing DTO and reconciles dirty/set state
per-path, leaving Get's full reseed unchanged.
Signed-off-by: Satya Krishna Pindiproli <satyak@qti.qualcomm.com>
satyakris
force-pushed
the
feature/gtv-implementation
branch
from
July 14, 2026 11:03
11a784a to
1a9ec4a
Compare
ramesh521
reviewed
Jul 14, 2026
satyakris
added a commit
to satyakris/audioreach-creator-ui
that referenced
this pull request
Jul 14, 2026
Fix tag-data API endpoint documentation to use the correct
two-segment path (tag-data/{tagSystemId}/{tkvSystemId}) matching
swagger and implementation.
Also close a design gap found in PR AudioReach#29 review (finding AudioReach#3):
FR-GS-02 previously specified the same full reseed-and-clear for
both Get and Set, which meant setPaths could never be populated.
Rewrite FR-GS-02/FR-ST-05 and design.md Sec 9.6, and add Sec 9.7,
to specify that Set instead merges the (possibly partial) backend
response into the existing DTO and reconciles dirty/set state
per-path, leaving Get's full reseed unchanged.
Signed-off-by: Satya Krishna Pindiproli <satyak@qti.qualcomm.com>
satyakris
force-pushed
the
feature/gtv-implementation
branch
from
July 14, 2026 16:57
1a9ec4a to
b7c7e2d
Compare
Add a PUT method to the shared HttpClient, mirroring patch (Content-Type application/json, same request/retry handling). Needed by the cal-data API wrapper for save requests. Signed-off-by: Satya Krishna Pindiproli <satyak@qti.qualcomm.com>
Add getCalData, putCalData, getTagData, and putTagData HTTP wrapper functions to the spf-module-data entity. Signed-off-by: Satya Krishna Pindiproli <satyak@qti.qualcomm.com>
Add the pure utilities the tree view builds on: element-key path helper, parse-hex-or-dec numeric parser, and patch-elements which applies edited values back onto the element tree. No React dependency; consumed by the rendering primitives and host. Signed-off-by: Satya Krishna Pindiproli <satyak@qti.qualcomm.com>
satyakris
added a commit
to satyakris/audioreach-creator-ui
that referenced
this pull request
Jul 15, 2026
Fix tag-data API endpoint documentation to use the correct
two-segment path (tag-data/{tagSystemId}/{tkvSystemId}) matching
swagger and implementation.
Also close a design gap found in PR AudioReach#29 review (finding AudioReach#3):
FR-GS-02 previously specified the same full reseed-and-clear for
both Get and Set, which meant setPaths could never be populated.
Rewrite FR-GS-02/FR-ST-05 and design.md Sec 9.6, and add Sec 9.7,
to specify that Set instead merges the (possibly partial) backend
response into the existing DTO and reconciles dirty/set state
per-path, leaving Get's full reseed unchanged.
Signed-off-by: Satya Krishna Pindiproli <satyak@qti.qualcomm.com>
satyakris
force-pushed
the
feature/gtv-implementation
branch
from
July 15, 2026 04:18
b7c7e2d to
bc7eb83
Compare
satyakris
commented
Jul 15, 2026
satyakris
added a commit
to satyakris/audioreach-creator-ui
that referenced
this pull request
Jul 15, 2026
Fix tag-data API endpoint documentation to use the correct
two-segment path (tag-data/{tagSystemId}/{tkvSystemId}) matching
swagger and implementation.
Also close a design gap found in PR AudioReach#29 review (finding AudioReach#3):
FR-GS-02 previously specified the same full reseed-and-clear for
both Get and Set, which meant setPaths could never be populated.
Rewrite FR-GS-02/FR-ST-05 and design.md Sec 9.6, and add Sec 9.7,
to specify that Set instead merges the (possibly partial) backend
response into the existing DTO and reconciles dirty/set state
per-path, leaving Get's full reseed unchanged.
Signed-off-by: Satya Krishna Pindiproli <satyak@qti.qualcomm.com>
satyakris
force-pushed
the
feature/gtv-implementation
branch
from
July 15, 2026 06:46
bc7eb83 to
695f111
Compare
Add the sub-components that render tree items and their leaves: element-table, element-tree, legacy-view, parameter-detail-pane, parameter-list-panel, toolbar, status-strip, view-switch-overlay, horizontal-guide-line, and the render-element dispatch. The QUI prop-leak suppressor in test-setup targets React 19. No host state; the host component consumes these next. Signed-off-by: Satya Krishna Pindiproli <satyak@qti.qualcomm.com>
Add GenericTreeView — the stateful host that orchestrates the rendering primitives. Wires the imperative handle, initialUiState/onUiStateChange, hideToolbar, autoCommit, and defaultPolicyFilter props. Manages elementValues, dirtyPaths, setPaths, invalidPaths, arrayCounts, and the tree/table view mode. Signed-off-by: Satya Krishna Pindiproli <satyak@qti.qualcomm.com>
Fix tag-data API endpoint documentation to use the correct
two-segment path (tag-data/{tagSystemId}/{tkvSystemId}) matching
swagger and implementation.
Also close a design gap found in PR AudioReach#29 review (finding AudioReach#3):
FR-GS-02 previously specified the same full reseed-and-clear for
both Get and Set, which meant setPaths could never be populated.
Rewrite FR-GS-02/FR-ST-05 and design.md Sec 9.6, and add Sec 9.7,
to specify that Set instead merges the (possibly partial) backend
response into the existing DTO and reconciles dirty/set state
per-path, leaving Get's full reseed unchanged.
Signed-off-by: Satya Krishna Pindiproli <satyak@qti.qualcomm.com>
satyakris
force-pushed
the
feature/gtv-implementation
branch
from
July 15, 2026 09:02
695f111 to
c2a9b14
Compare
ramesh521
approved these changes
Jul 15, 2026
ramesh521
merged commit Jul 15, 2026
0fcc845
into
AudioReach:feature/use-case-designer
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add utilities, rendering primitives and the generic tree view host component along with adding
PUTto the existing http client andspf-module-dataentity API to get and set cal data to the backend.